-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows Server SSH Remoting Fails if Server has Win32_OpenSSH 7.9 or newer installed #2475
Comments
That's right - the fix will be in the next major windows update. No need to ping the whole team. I have assumed that most people are not installing newer versions of OpenSSH manually so I have not tried to work around it. I'm curious why you installed v8 at first instead of installing the default build through windows? |
@roblourens Just because those were additional that Tyler flagged for visibility in the previous issue, that's all. As to the version, we use the Kerberos GSSAPI functionality extensively which requires 7.9, and win32_openssh is easy to deploy with chocolatey :) Is the problem a downstream issue in windows? Is there a reason just an update to the extension can't fix the issue? Thanks for your hard work. |
Thanks for trying it, and for your tweet! I will leave this issue open for now to judge whether this ends up being a common scenario. The upstream issue is PowerShell/Win32-OpenSSH#1545 (fixed internally but not in a release yet) |
Thanks! Once that gets released I'll try it and if so the remediation will be to just deploy the latest openssh version out-of-band from an OS release if you need 7.9+ features. |
For anyone else finding this issue, a workaround is to set the following "remote.SSH.useLocalServer": false,
"remote.SSH.windowsRemotes": ["<your remote's hostname>"] |
@roblourens At least for me when disabling useLocalServer (already had server in windowsRemotes), it completely hangs here and never continues. This is true for both less and greater than 7.9
|
Can you share the log? That looks like output from the connection in the terminal which should never terminate. |
@roblourens which log specifically? Do you have a bug report guide? |
And basically what I'm saying is, it's ok if that terminal doesn't quit but vscode should connect (you should be able to open files and so on, and the progress spinner in the lower left corner should go away) |
Got it, thanks. I have a pressing item I need to address but I'll do some full testing and report back. |
Do you have |
Is this issue in Windows itself or the version of ssh shipped with windows? Do to #2512 I installed the SSH nightly extension. I have since set the extension settings back to default. On my host I have openssh installed from Windows optional feature and ssh installed from git. The VS Code SSH extension is once again finding ssh.exe which is installed with git. Using ssh installed with git appears to be the preferred approach #2512 Comment. I'm trying to connect to a Windows 8 machine running log
|
@soul4soul that looks like an older version of the nightly ssh extension |
@roblourens as far as I can see this is still a problem
|
Can you share the full log and the ssh settings you have? There have been a bunch of changes since March. You may need
if you have overridden these but the defaults should work |
This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines. Happy Coding! |
This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines. Happy Coding! |
This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines. Happy Coding! |
Suffering the same fate. Reason for upgrading to the newer 8.1 build was because there is a known issues with SCP and the 7.x builds of OpenSSH. So remote coding works on 7.x but then I can't use the server for SCP from Cisco devices. Upgrade to 8.x, and now I can SCP, but I can't get VSCode to work with any permutation. So.... just thought I'd drop this out here, there are good reasons to upgrade to 8 for compatibility... But then we get sunk on remote development. |
Is there an issue opened in the Win32-OpenSSH repo? |
@bagajjal The issue is how vscode remoting interprets the shell messages, v8 sends different messages and remoting doesn't parse them correctly, so this is not an OpenSSH issue to fix but a vscode one. I would fix it myself but unfortunately the source is not open for review. |
@JustinGrote, Thanks for your quick reply. |
I tested this with 8.1 and the only issue I see is the previously identified one, which only reproes when the The |
Probably the same issue still here. `[07:01:32.330] Log Level: 2 [07:01:32.364] Remote command length: 5899/8192 characters FYI SSH works fine from console, several remotes work fine to Linux remotes. |
I have a workaround for this which will be in tomorrow's Remote-SSH Nightly build. Would appreciate anyone who has run into this trying it out. Essentially it will retry on the first attempt (so you may see a password prompt twice) then write the platform to the |
@roblourens I'll give it a shot |
@JustinGrote did you get the chance to give this a shot? |
I think I had other issues that werent directly related. I'll put it on my to-do list, ping me in a week :) |
Verification steps - if you have all windows updates installed, you may have SSH 7.9+ already. If not, install it from https://github.com/PowerShell/Win32-OpenSSH/releases/tag/v8.1.0.0p1-Beta (download and run install-sshd.ps1). Try to connect with Remote-SSH. If you use password auth, you may get prompted twice. If you connect successfully, it works. |
Steps to Reproduce:
It is noted the regression is probably in 7.9 here:
#25 (comment)
And whatever code is used to parse out the remote port from the server output needs to detect this newer format in Windows OpenSSH and parse that newer format instead.
Does this issue occur when you try this locally?: N/A
Does this issue occur when you try this locally and all extensions are disabled?: N/A
Related Info: #25
@bagajjal @manojampalam @TylerLeonhardt @roblourens
The text was updated successfully, but these errors were encountered: