Move attached containers to dev containers

[dbaeumer]

Testing #1938

The container is still shown as attached although I closed the VS Code instance that was attached to it.

[alexr00]

"Attached Containers" are containers that you can attach to or have attached to. This looks correct since it doesn't have the green currently-connected-with-this-window icon.

[vscodebot]

The described behavior is how it is expected to work. If you disagree, please explain what is expected and what is not in more detail. See also our issue reporting guidelines.

Happy Coding!

[dbaeumer]

I have to say that the wording is pretty misleading. For me "Attached Containers" are containers I am attached to :-) I would never look for a green circle

[dbaeumer]

And actually it is not true. This container I have been attached to and now shows up as Other Containers.

[dbaeumer]

[alexr00]

We only move the container from Other to Attached once you've opened a folder.

[dbaeumer]

I would have never guessed this :-).

I am also not convinced that this is something others will understand easily. Is this not something that is more a Favorite or Last recently used concept. That I would understand :-)

[alexr00]

That's actually what we're using to tell whether a container is Attached or Other. We use the recently opened folders and populate much of the view from there.
@chrmarti what do you think of changing "Attached" to "Recently Attached"?

[chrmarti]

The currently attached container would also show under "Recently Attached"? 🤔

[alexr00]

Yes, it would just be a string change in the tree.

[chrmarti]

The distinction between Attached Containers and Dev Containers is becoming more artificial as we extend the attach case. Maybe we could have them all under Dev Containers.

[dbaeumer]

That makes sense to me. We could also think about removing Dev and simply call them containers. I know that I am developing :-)

[alexr00]

Attached containers now show under Dev containers. They do still have different actions since that is needed.