Yapf format sometimes doesn't work

[toplinuxsir]

Environment data

VS Code version: 1.8.1
Python Extension version: 0.8
Python Version: 3.6.2
OS and version: windows 10

Actual behavior

yapf format not working occasionlly

Expected behavior

format the python source code

Steps to reproduce:

Set vscode format when save
and modify python source code when save

Logs

Output from Python output panel

Output from Console window (Help->Developer Tools menu)

workbench.main.js:sourcemap:10 spawn ctags ENOENT: Error: spawn ctags ENOENT
	at exports._errnoException (util.js:1050:11)
	at Process.ChildProcess._handle.onexit (internal/child_process.js:193:32)
	at onErrorNT (internal/child_process.js:367:16)
	at _combinedTickCallback (internal/process/next_tick.js:80:11)
	at process._tickCallback (internal/process/next_tick.js:104:9)
e.onUnexpectedError @ workbench.main.js:sourcemap:10
workbench.main.js:sourcemap:9 [Extension Host] (node:440) DeprecationWarning: os.tmpDir() is deprecated. Use os.tmpdir() instead.
t.log @ workbench.main.js:sourcemap:9
9workbench.main.js:sourcemap:9 [Extension Host] (node:440) DeprecationWarning: Calling an asynchronous function without callback is deprecated.
t.log @ workbench.main.js:sourcemap:9
10workbench.main.js:sourcemap:9 [Extension Host] (node:440) DeprecationWarning: Calling an asynchronous function without callback is deprecated.
t.log @ workbench.main.js:sourcemap:9
t._logExtensionHostMessage @ workbench.main.js:sourcemap:9
(anonymous) @ workbench.main.js:sourcemap:9
emitTwo @ events.js:106
emit @ events.js:194
process.nextTick @ internal/child_process.js:766
_combinedTickCallback @ internal/process/next_tick.js:73
_tickCallback @ internal/process/next_tick.js:104
workbench.main.js:sourcemap:9 [Extension Host] ApplicationInsights:Sender [Object]
t.log @ workbench.main.js:sourcemap:9
t._logExtensionHostMessage @ workbench.main.js:sourcemap:9
(anonymous) @ workbench.main.js:sourcemap:9
emitTwo @ events.js:106
emit @ events.js:194
process.nextTick @ internal/child_process.js:766
_combinedTickCallback @ internal/process/next_tick.js:73
_tickCallback @ internal/process/next_tick.js:104

[toplinuxsir]

The bug exist from version 0.5

[mkalakota]

I receive a different error for vscode version 1.19.1

TypeError: Cannot read property 'text' of undefined
	at HelpCompletionFeature.onEvent (C:\Users\Mouli Kalakota\.vscode\extensions\ms-vscode.powershell-1.5.1\out\src\features\HelpCompletion.js:34:100)
	at e.fire (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:87:238)
	at e.$acceptDirtyStateChanged (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:432:782)
	at e.$acceptModelSaved (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:432:565)
	at t.e.invoke (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:516:87)
	at e._invokeHandler (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:357:580)
	at e._receiveOneMessage (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:357:270)
	at c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:356:206
	at c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:358:204
	at c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:85:988
	at e.fire (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:87:218)
	at Socket.<anonymous> (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:135:717)
	at emitOne (events.js:96:13)
	at Socket.emit (events.js:191:7)
	at readableAddChunk (_stream_readable.js:178:18)
	at Socket.Readable.push (_stream_readable.js:136:10)
	at Pipe.onread (net.js:560:20)

[MikhailArkhipov]

Appears to be PowerShell extension judging from
**ms-vscode.powershell-1.5.1**\out\src\features\HelpCompletion.js
You may want to report it at https://github.com/PowerShell/vscode-powershell

[MikhailArkhipov]

@toplinuxsir - is it broken occasionally at any time or is it not working for some time after opening first Python file? The latter is because it actually takes a few seconds for the extension to load (VSC keeps UI accessible) - for example, Format Document command may not be available in context menu right after the file is opened.

[bcatubig]

I've noticed this issue as well when running in a virtualenv. My vscode python interpreter is defined and auto-format on save is set to true

Seems to be random when it works and when it doesn't. Is there any way to catch log output for the autoformat event?

[brettcannon]

@bcatubig anything we log goes to the Output window (found under View). If you want to be truly daring/helpful, you could instrument your own build of the extension to try and catch the failure (if you need help instrumenting, let us know and we can try and point you at the right spot).

[bcatubig]

Hey @brettcannon,

I've found that by removing python.formatting.autopep8Args from my vs code config, autopep8 starts working again. It seems to stop working when this is defined.

Here is what I was using

    "python.formatting.autopep8Args": [
        "--experimental",
        "--max-line-length 120",
    ],

[brettcannon]

@bcatubig could you try it again without the --experimental line but with the --max-line-length 120? It would be good to know if it's purely the --experimental flag that breaks things.

[bcatubig]

@brettcannon ,

I receive errors with the following settings

"python.formatting.autopep8Args": [
        "--max-line-length 120",
    ]

here is the log from Output

Formatting with autopep8 failed.
Command failed: autopep8 --max-line-length 120 --diff --diff --diff /Users/brandon/code/test.py
usage: autopep8 [-h] [--version] [-v] [-d] [-i] [--global-config filename]
                [--ignore-local-config] [-r] [-j n] [-p n] [-a]
                [--experimental] [--exclude globs] [--list-fixes]
                [--ignore errors] [--select errors] [--max-line-length n]
                [--line-range line line]
                [files [files ...]]
autopep8: error: unrecognized arguments: /Users/brandon/code/test.py

[DonJayamanne]

@bcatubig Please could you try with the following settings:

"python.formatting.autopep8Args": [
        "--max-line-length" , "120",
    ]

[bcatubig]

@DonJayamanne That seems to have done the trick. autopep8 works now without error.

[brettcannon]

@toplinuxsir @mkalakota do either of you happen to have custom yapf configuration settings in your settings.json file(s)?

[DonJayamanne]

Summarizing:

• @bcatubig the problem has been resolved for you. Great.
• @toplinuxsir the problem has been resolved for you too in Yapf formatter sometimes doesn't work #427

@mkalakota Please could you confirm you are still experiencing this issue.

[mkalakota]

@brettcannon No, I do not have any custom yapf configuration

@DonJayamanne Yes, it works now. Although, I'm not sure which update resolved the issue, vscode or the plugin

[DonJayamanne]

Thanks for getting back