Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for pipenv/Pipfile detection #1007

Closed
brettcannon opened this issue Mar 9, 2018 · 3 comments
Closed

Add unit tests for pipenv/Pipfile detection #1007

brettcannon opened this issue Mar 9, 2018 · 3 comments
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Milestone

Comments

@brettcannon
Copy link
Member

It would seem there are either no unit tests or they are "broken" from the perspective of what they are testing since the Pipfile/pipfile fix didn't fail either.

@brettcannon brettcannon added needs PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. labels Mar 9, 2018
@brettcannon brettcannon added this to the March 2018 milestone Mar 9, 2018
@DonJayamanne
Copy link

We do have some tests, but we've missed some areas (its a coverage issue).
https://codecov.io/gh/Microsoft/vscode-python/src/master/src/client/interpreter/locators/services/pipEnvService.ts#L75

Question is should we aim for a higher coverage?

@MikhailArkhipov
Copy link

I think in this particular case factor is a combination of specific OS and use of mocks. Test needs to run on proper platform with real workspace on disk rather than via simulated file system mock.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Development

No branches or pull requests

3 participants