Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invisible Button/Input Text in High Contrast Themes #3342

Closed
daviddossett opened this issue Feb 23, 2022 · 0 comments · Fixed by #3343
Closed

Invisible Button/Input Text in High Contrast Themes #3342

daviddossett opened this issue Feb 23, 2022 · 0 comments · Fixed by #3343
Assignees
@daviddossett @alexr00
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
April 2022

Comments

@daviddossett
Copy link
Contributor

  • Extension version: v0.36.2
  • VSCode Version: 1.65.0
  • OS: macOS 12.2.1

Steps to Reproduce:

  1. Open a PR description or start creating a new PR
  2. Switch to light HC theme (only available in Insiders right now)
  3. Notice buttons have invisible foreground text

Examples

CleanShot 2022-02-22 at 11 52 19@2x

CleanShot 2022-02-22 at 11 52 14@2x

CleanShot 2022-02-22 at 11 52 10@2x

This is expected since there is a rule setting background: none ~important. PR to follow 👍
@daviddossett daviddossett self-assigned this Feb 23, 2022
@daviddossett daviddossett mentioned this issue Feb 23, 2022
Merged
@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Feb 28, 2022
@alexr00 alexr00 added this to the March 2022 milestone Feb 28, 2022
@alexr00 alexr00 self-assigned this Feb 28, 2022
@alexr00 alexr00 modified the milestones: March 2022, April 2022 Mar 21, 2022
@alexr00 alexr00 mentioned this issue Mar 28, 2022
Closed
@aeschli aeschli added the verified Verification succeeded label Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daviddossett daviddossett

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
April 2022
Development

Successfully merging a pull request may close this issue.

Update high contrast styles for buttons and inputs microsoft/vscode-pull-request-github
3 participants
@aeschli @daviddossett @alexr00