Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A comment added on the right side of a diff editor may move to the left side on reload #153

Closed
RMacfarlane opened this issue Aug 9, 2018 · 1 comment
Labels
github Related to GitHub API ux

Comments

@RMacfarlane
Copy link
Contributor

  1. Open a file change from the PR tree
  2. Add a new comment on the right hand side of the diff editor, on a line that isn't within an addition
  3. Close and reopen the file change. Comment now appears on the base file on the left

Since the comment isn't on an addition, showing it on the base file is the correct thing to do. However, it's confusing to have it move - I thought a comment had been lost for a second because it wasn't where I had added it.
comment_move

On GitHub, trying to add such a comment, the comment widget pops up on the left even though the click was on the right:
lhs_comment

@RMacfarlane RMacfarlane added the ux label Aug 9, 2018
@rebornix
Copy link
Member

rebornix commented Aug 9, 2018

We need some specific github review logic to adjust the commenting range for the modified editor.

@rebornix rebornix added the github Related to GitHub API label Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github Related to GitHub API ux
Projects
None yet
Development

No branches or pull requests

2 participants