Cache activated env variables if it takes >=500ms to activate #8363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
commented
Nov 24, 2021
| * We cache activated environment variables. | ||
| * When activating environments, all activation scripts update environment variables, nothing else (after all they don't start a process). | ||
| * The env variables can change based on the activation script, current env variables on the machine & python interpreter information. | ||
| * If any of these change, then the env variables are invalidated. |
There was a problem hiding this comment.
Heres an update of the logic
There was a problem hiding this comment.
This basically brings down activation from 14s to 5-6s.
IanMatthewHuff
approved these changes
Nov 24, 2021
Codecov Report
@@ Coverage Diff @@
## main #8363 +/- ##
=====================================
- Coverage 71% 71% -1%
=====================================
Files 375 375
Lines 23746 23788 +42
Branches 3653 3662 +9
=====================================
+ Hits 17080 17103 +23
- Misses 5186 5199 +13
- Partials 1480 1486 +6
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #7952