-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code navigation to third party libraries does not work in the Jupyter notebooks. #867
Comments
@subhashbylaiah . Thanks for the report on this. As it currently is implemented notebook support is added in as an independent webview, we've tried to make it match the VSCode editors as much as we can, but many code navigation and extension features are currently not supported in it. The good news is that the VSCode core team is currently in process of adding in full notebook UI support to the main VSCode product. When this comes online, our extension will move over to using that and this issue should be resolved. You can track the main VSCode issue here: |
I'm going to close this issue for now as we will not be fixing it in our current implementation, but the new notebook implementation should be releasing soon in preview form soonish, and you can check out this feature when that happens. |
Ok, thanks |
Hey @IanMatthewHuff 👋 |
@roma-glushko It's coming along, but in Preview form now. If you download VS Code - Insiders (it's totally SxS safe with regular stable VS Code) then the new UI implementation is the default there. Check it out and see if it works there for you. |
@IanMatthewHuff wow new look and feel of Jypiter integration is fantastic 💫 So much better than PyCharm integration 💪 I do see go to definition features but they seem to apply to local notebook variables only. Is it possible to navigate code imported from 3rd-party libs and modules just like it's possible to do from regular python script file? |
@roma-glushko Hmm, I thought that would have been working. I'll reopen this issue and we can check. |
This should be working now on our latest insiders (and with latest Pylance insiders). Pylance actually provides goto definition. |
Verification steps: Add sklearn to an environment
Right click on LabelEncoder and click goto definition. |
Bug: Notebook Editor, Interactive Window, Editor cells
Steps to cause the bug to occur
Open a notebook (.ipynb file) or create one with some test code (just define a variable and access it from a subsequent cell)
⌘+Click should take you to the variable/function definition and this does not happen.
Actual behavior
Expected behavior
Your Jupyter and/or Python environment
Please provide as much info as you readily know
Developer Tools Console Output
Microsoft Data Science for VS Code Engineering Team: @rchiodo, @IanMatthewHuff, @DavidKutu, @DonJayamanne, @greazer, @joyceerhl
The text was updated successfully, but these errors were encountered: