Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto completion is suggesting completely invalid suggestions. #7136

Closed
greazer opened this issue Aug 14, 2021 · 2 comments · Fixed by #8247
Closed

Auto completion is suggesting completely invalid suggestions. #7136

greazer opened this issue Aug 14, 2021 · 2 comments · Fixed by #8247
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug notebook-intellisense Intellisense & other language features in notebook cells for any language papercut 🩸 Something affecting the productivity of the team verified Verification succeeded
Milestone

Comments

@greazer
Copy link
Member

greazer commented Aug 14, 2021

Version: 1.60.0-insider (user setup)
Commit: 58454f7bec838f79fe2422ab5914419147d82e40
Date: 2021-08-13T05:15:29.421Z
Electron: 13.1.8
Chrome: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 10.0.22000

Jupyter: v2021.8.2027072902
Pylance: v2021.8.2-pre.1

  1. Create a new ipynb that has nothing to do with another that exists in the same workspace.
  2. In the new notebook type
import pandas as pd

Notice that pd gets offered to be autocompleted as one of the files in the workspace. This is totally invalid. This doesn't happen in a py file in the same workspace following the same procedure.

I'm also not sure whether this bug is a Jupyter or PyLance problem, though I'm guessing Jupyter at this point.

recording (6)

@greazer greazer added bug Issue identified by VS Code Team member as probable bug notebook-intellisense Intellisense & other language features in notebook cells for any language labels Aug 14, 2021
@greazer greazer added papercut 🩸 Something affecting the productivity of the team and removed needs-triage labels Aug 16, 2021
@greazer
Copy link
Member Author

greazer commented Aug 16, 2021

The autocomplete is coming from the Jupyter Kernel. Would be great to find a way to make this a more reasonable experience.

Perhaps only accept jupyter kernel autocomplete when specific characters are typed... like '.' or "'", etc.

@rchiodo rchiodo self-assigned this Aug 31, 2021
@rchiodo rchiodo added this to the September 2021 milestone Aug 31, 2021
@greazer greazer modified the milestones: September 2021, October 2021 Sep 23, 2021
@rchiodo rchiodo modified the milestones: October 2021, November 2021 Oct 27, 2021
@rchiodo
Copy link
Contributor

rchiodo commented Nov 10, 2021

Autocomplete from jupyter outside of a string that returns file paths seems useless. That would alleviate this problem.

We could filter based on if inside a string or not.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug notebook-intellisense Intellisense & other language features in notebook cells for any language papercut 🩸 Something affecting the productivity of the team verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants