Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perf Measurements, improvements #5324

Closed
DonJayamanne opened this issue Mar 25, 2021 · 1 comment
Closed

Perf Measurements, improvements #5324

DonJayamanne opened this issue Mar 25, 2021 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug notebook-execution Kernels issues (start/restart/switch/execution, install ipykernel) perf Performance issues

Comments

@DonJayamanne
Copy link
Contributor

DonJayamanne commented Mar 25, 2021

Opening Notebooks

  • Start time - when we get a request to provide contents to VS Code
  • End Time A - when we get the event that a notebook was opened
  • End Time B - when we get a message from kernel.js loaded in Renderer (today we do this in resolve, to keep IPYWidgets kernel ready)

Fetching Kernels

  • Today when we fetch kernels, its slow, can be very slow on some OS
  • We can easily cache this & find the preferred kernel from the cache
  • If we fine the preferred kernel from cache & its valid, then we can use that
  • We can always start off the kernel fetch in the background as well
  • If we have metadata & have cached kernels, and the kernel exists in the cache, just check if the kernel is valid (file exists/interpreter exists), that should be sufficient (faster than loading all interpreters & searching the fs).
@DonJayamanne DonJayamanne added the bug Issue identified by VS Code Team member as probable bug label Mar 25, 2021
@DonJayamanne DonJayamanne changed the title Perf Measurements, ideas Perf Measurements, improvements Mar 29, 2021
@greazer greazer added this to the May 2021 Release milestone Apr 1, 2021
@greazer greazer added the notebook-execution Kernels issues (start/restart/switch/execution, install ipykernel) label Apr 26, 2021
@greazer greazer modified the milestones: May 2021 Release, June 2021 Release Apr 26, 2021
@greazer greazer modified the milestones: August 2021, old August 2021 Aug 9, 2021
@DonJayamanne DonJayamanne self-assigned this Aug 15, 2022
@DonJayamanne
Copy link
Contributor Author

Not required anymore

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug notebook-execution Kernels issues (start/restart/switch/execution, install ipykernel) perf Performance issues
Projects
None yet
Development

No branches or pull requests

2 participants