Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt EnvironmentVariableCollection.description #1712

Closed
Tyriar opened this issue Jun 5, 2023 · 3 comments · Fixed by #1725
Closed

Adopt EnvironmentVariableCollection.description #1712

Tyriar opened this issue Jun 5, 2023 · 3 comments · Fixed by #1725
Assignees
Labels
debt Code quality issues
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 5, 2023

There's a new API (microsoft/vscode#171108) being finalized this month that allows extensions to explain why it's changing environment variables. Adopting this will show additional information when hovering a terminal tab

API:

https://github.com/microsoft/vscode/blob/e6936ce0ab10bc9fb3ec220db3c4304bdd909292/src/vscode-dts/vscode.proposed.envCollectionWorkspace.d.ts#L27-L33

Current:

image

After description:

image

cc @karrtikr

@karrtikr
Copy link

Was this verified?

@connor4312
Copy link
Member

It was not marked as a feature/bug, though Daniel tested it out (and found microsoft/vscode#186859)

@Tyriar
Copy link
Member Author

Tyriar commented Jul 10, 2023

Also: microsoft/vscode#186798

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Code quality issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants