Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a way to customize the visibility of 'run' and 'debug' CodeLens #374

Closed
ThadHouse opened this issue Nov 2, 2018 · 4 comments · Fixed by #734
Closed

Add a way to customize the visibility of 'run' and 'debug' CodeLens #374

ThadHouse opened this issue Nov 2, 2018 · 4 comments · Fixed by #734
Labels
enhancement
Milestone
0.18.1

Comments

@ThadHouse
Copy link

I have a build where if you just attempt to run any test functions, it fails to start, because I have some native dependencies that need to be configured. I am providing this build to a large amount of users, and it is confusing our users, as those buttons do not work, and they throw very confusing errors. Could a property be added to disable these buttons from showing up?

PR is #373

There was the same issue for the debug extension that was accepted.

microsoft/vscode-java-debug#464
@jdneo
Copy link
Member

jdneo commented Nov 2, 2018

@ThadHouse Is it possible to share a sample project to us?

We would like to see why codelens is not working.

@ThadHouse
Copy link
Author

ThadHouse commented Nov 2, 2018 •
edited by jdneo
Loading

I just did in the PR. I have some weird setups where the arguments and inputs needed for the tests to run change every build, and its hard to reproduce those. But the sample I posted gets close.

@jdneo
Copy link
Member

jdneo commented Nov 9, 2018

Hi @ThadHouse,

Sorry that we did some refactoring these days causing the conflicts in the PR. It will be great if you would like to resolve them.

@ThadHouse
Copy link
Author

I will tomorrow.

@jdneo jdneo changed the title Add way to disable test and debug buttons on test function definitions Add way to disable 'test' and 'debug' Code Lens Jun 20, 2019
@jdneo jdneo changed the title Add way to disable 'test' and 'debug' Code Lens Add a way to customize the visibility of 'test' and 'debug' Code Lens Jun 20, 2019
@jdneo jdneo changed the title Add a way to customize the visibility of 'test' and 'debug' Code Lens Add a way to customize the visibility of 'run' and 'debug' Code Lens Jun 20, 2019
@jdneo jdneo mentioned this issue Jun 20, 2019
Merged
@jdneo jdneo added this to the 0.18.1 milestone Jun 20, 2019
@jdneo jdneo changed the title Add a way to customize the visibility of 'run' and 'debug' Code Lens Add a way to customize the visibility of 'run' and 'debug' CodeLens Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
0.18.1
2 participants
@jdneo @ThadHouse