Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a setting to stop automatically tag parsing all headers under the current workspace folder #6827

Closed
sean-mcmanus opened this issue Jan 21, 2021 · 2 comments
Labels
enhancement Improvement to an existing feature Feature: Configuration An issue related to configuring the extension or IntelliSense Feature: Symbol Search Language Service performance
Milestone

Comments

@sean-mcmanus
Copy link
Contributor

Currently, headers under the workspace folder are always tag parsed, even if they're not #included. This decision was made before multi-root workspaces were possible in which users could add large external libraries with lots of headers that aren't used, but can increase the database size and decrease performance (see #6801).

Most of the work involved is just adding the setting and plumbing it through, similar to what is already done for the limitSymbolsToIncludedHeaders setting.

@sean-mcmanus sean-mcmanus added Language Service performance Feature: Configuration An issue related to configuring the extension or IntelliSense Feature: Symbol Search enhancement Improvement to an existing feature labels Jan 21, 2021
@Colengms Colengms added this to the Triage milestone Jan 21, 2021
@bobbrow bobbrow modified the milestones: Triage, On Deck Jan 28, 2021
@bobbrow
Copy link
Member

bobbrow commented Dec 9, 2022

I don't think we want to do this. At some point we'd like to have a feature that will allow us to suggest types that have not yet been #included. Auto-completing those types would also add the #include statement.

@sean-mcmanus
Copy link
Contributor Author

Sure, I'll close this.

@sean-mcmanus sean-mcmanus closed this as not planned Won't fix, can't repro, duplicate, stale Dec 15, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Improvement to an existing feature Feature: Configuration An issue related to configuring the extension or IntelliSense Feature: Symbol Search Language Service performance
Projects
None yet
Development

No branches or pull requests

3 participants