Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snippet strings are not localized #4482

Closed
sean-mcmanus opened this issue Oct 23, 2019 · 7 comments
Closed

Snippet strings are not localized #4482

sean-mcmanus opened this issue Oct 23, 2019 · 7 comments
Assignees
Labels
bug Feature: Auto-complete fixed Check the Milestone for the release in which the fix is or will be available. Language Service world ready An issue relating string character encodings, localization translations, etc.
Milestone

Comments

@sean-mcmanus
Copy link
Contributor

Change the display language, and then invoke autocomplete. The various strings shown in completion/snippet results from the engine are not translated.

@sean-mcmanus sean-mcmanus added bug Language Service Feature: Auto-complete more votes needed Issues that have been postponed until more community members upvote it world ready An issue relating string character encodings, localization translations, etc. labels Oct 23, 2019
@bobbrow bobbrow added this to the Backlog milestone Feb 20, 2020
@michelleangela
Copy link
Contributor

Is this a duplicate of #5370?

@sean-mcmanus sean-mcmanus changed the title Autocomplete and snippets strings are not localized Snippet strings are not localized Sep 17, 2020
@sean-mcmanus
Copy link
Contributor Author

The autocomplete part was a duplicate, but the snippet part is not.

The snippets code needs a re-architecting though, to enable user-modification via sending the snippets from a TypeScript or a custom snippets json file, so I'm not sure if it's worth the effort to localize.

But the detail text "Code snippet for" could be easily localized.

@Colengms Colengms modified the milestones: Backlog, Triage Oct 16, 2020
@bobbrow bobbrow removed the more votes needed Issues that have been postponed until more community members upvote it label Oct 29, 2024
@bobbrow bobbrow moved this to Todo in cpptools Oct 29, 2024
@bobbrow bobbrow modified the milestones: Triage, On Deck Oct 29, 2024
@Yingzi1234
Copy link

@bobbrow @sean-mcmanus Regarding the autocomplete part of this issue we verified that it has been fixed in the latest C/C++ version v1.23.0(pre-release). However, we don't know how to verify the snippet part of the issue. Could you please tell us the steps to verify it? Thank you very much in advance!

autocomplete part
Image
Image
Image

@bobbrow
Copy link
Member

bobbrow commented Oct 31, 2024

Hi @Yingzi1234, the snippets have not yet passed through localization. We will close this issue when that is ready for testing.

@Yingzi1234
Copy link

@bobbrow Got it! Thank you for your reply!

@sean-mcmanus sean-mcmanus self-assigned this Dec 9, 2024
@sean-mcmanus sean-mcmanus moved this from Todo to Pull Request in cpptools Dec 9, 2024
@sean-mcmanus sean-mcmanus moved this from Pull Request to In progress in cpptools Dec 9, 2024
@sean-mcmanus sean-mcmanus moved this from In progress to Todo in cpptools Dec 10, 2024
@bobbrow bobbrow moved this from Todo to In progress in cpptools Dec 10, 2024
@sean-mcmanus sean-mcmanus modified the milestones: On Deck, 1.23 Dec 11, 2024
@sean-mcmanus
Copy link
Contributor Author

None of the TypeScript snippets are localized translated and Copilot suggested that the stuff directly related to code would be better left untranslated so I'm not translating anything, but I made some minor updates to the detail text to make it match TypeScript more, I got rid of the "Code snippet for" text, and I got rid of the MIT License snippet.

@sean-mcmanus sean-mcmanus moved this from In progress to Pull Request in cpptools Dec 12, 2024
@sean-mcmanus sean-mcmanus moved this from Pull Request to Done in cpptools Dec 19, 2024
@sean-mcmanus sean-mcmanus removed this from the 1.23 milestone Dec 19, 2024
@sean-mcmanus sean-mcmanus added this to the 1.23.3 milestone Dec 19, 2024
@sean-mcmanus sean-mcmanus added the fixed Check the Milestone for the release in which the fix is or will be available. label Dec 19, 2024
@sean-mcmanus
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Feature: Auto-complete fixed Check the Milestone for the release in which the fix is or will be available. Language Service world ready An issue relating string character encodings, localization translations, etc.
Projects
Status: Done
Development

No branches or pull requests

5 participants