Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Click to preview" is disabled for "Peek References" #4040

Closed
sean-mcmanus opened this issue Aug 9, 2019 · 1 comment
Closed

"Click to preview" is disabled for "Peek References" #4040

sean-mcmanus opened this issue Aug 9, 2019 · 1 comment
Labels
Feature: Find All References Find All References, Peek References, Rename Feature Request Language Service more votes needed Issues that have been postponed until more community members upvote it Works in VS So we'd need to fix it for VS Code to reach parity.
Milestone
Triage

Comments

@sean-mcmanus
Copy link
Contributor

sean-mcmanus commented Aug 9, 2019 •
edited
Loading

Find All References allows previewing of the current results via clicking the search icon, but Peek References has this disabled because when we re-issue the Peek Reference and the cursor hasn't moved then the Peek Reference dialog box disappears. It's possible there might be a way to add some workaround? Let me know if anyone thinks they know how to fix this in the open source TypeScript -- the VS Code team is telling us they don't want us to implement "click to preview" and want to implement "streaming", but there's no ETA for that. See microsoft/vscode#77617 and microsoft/vscode#20010 .

UPDATE: The preview can be shown in the Output window as a "Confirmed Reference" -- related work needs to be done for Rename anyway.

There was also a minor bug where it would say "Confirmation in progress" if the peek window was closed instead of "Confirmation canceled".
@sean-mcmanus sean-mcmanus added Language Service help wanted Can be fixed in the public (open source) repo. more votes needed Issues that have been postponed until more community members upvote it Works in VS So we'd need to fix it for VS Code to reach parity. Feature: Find All References Find All References, Peek References, Rename Feature Request labels Aug 9, 2019
@sean-mcmanus sean-mcmanus removed the more votes needed Issues that have been postponed until more community members upvote it label Aug 30, 2019
@sean-mcmanus sean-mcmanus added this to the 0.26.0 milestone Aug 30, 2019
@sean-mcmanus sean-mcmanus added fixed Check the Milestone for the release in which the fix is or will be available. and removed help wanted Can be fixed in the public (open source) repo. labels Aug 30, 2019
@sean-mcmanus sean-mcmanus mentioned this issue Sep 6, 2019
Merged
@sean-mcmanus sean-mcmanus removed the fixed Check the Milestone for the release in which the fix is or will be available. label Sep 20, 2019
@sean-mcmanus sean-mcmanus removed this from the 0.26.0 milestone Sep 20, 2019
@sean-mcmanus sean-mcmanus added the more votes needed Issues that have been postponed until more community members upvote it label Sep 20, 2019
@bobbrow
Copy link
Member

bobbrow commented Mar 19, 2020

Not seeing a lot of feedback on this. Closing...

@bobbrow bobbrow closed this as completed Mar 19, 2020
@Colengms Colengms added this to the Triage milestone Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature: Find All References Find All References, Peek References, Rename Feature Request Language Service more votes needed Issues that have been postponed until more community members upvote it Works in VS So we'd need to fix it for VS Code to reach parity.
Projects
None yet
Milestone
Triage
Development

No branches or pull requests
3 participants
@bobbrow @sean-mcmanus @Colengms