Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSP requests processed by protocolFilter.ts stall all other requests #12905

Closed
Colengms opened this issue Oct 29, 2024 · 1 comment
Closed

LSP requests processed by protocolFilter.ts stall all other requests #12905

Colengms opened this issue Oct 29, 2024 · 1 comment
Labels
bug fixed Check the Milestone for the release in which the fix is or will be available. Language Service
Milestone

Comments

@Colengms
Copy link
Contributor

In protocolFilter.ts, we are intentionally sequencing the message handlers, to ensure async calls within them can complete before the next message is processed. That ensure our use of async doesn't cause messages to be delivered out of order (i.e. something file-specific delivered before didOpen is processed for that file). However, that appears to also be awaiting the results of request operations, causing the protocol filter to effectively stall all other requests (including those done via languageClient.sendRequest) whenever there is an outstanding request for one of the LSP requests processed there:

provideCompletionItem
resolveCompletionItem
provideSignatureHelp
provideDefinition
provideReferences
provideDocumentHighlights
provideDeclaration
@Colengms Colengms added this to the 1.23 milestone Oct 29, 2024
@Colengms Colengms self-assigned this Oct 29, 2024
@Colengms Colengms moved this to In progress in cpptools Oct 29, 2024
@Colengms Colengms moved this from In progress to Done in cpptools Oct 30, 2024
@Colengms Colengms added the fixed Check the Milestone for the release in which the fix is or will be available. label Oct 30, 2024
@Colengms Colengms removed their assignment Oct 30, 2024
@heartacker
Copy link

good

@sean-mcmanus sean-mcmanus modified the milestones: 1.23, 1.23.1 Nov 9, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fixed Check the Milestone for the release in which the fix is or will be available. Language Service
Projects
Status: Done
Development

No branches or pull requests

3 participants