0.22.0: Language server crash in translate_encoding_to_utf8

[tuxStarElan]

Environment

• OS and Version: Linux x64 4.18.0-553.16.1.el8_10.x86_64
• VS Code Version: 1.92.2
• C/C++ Extension Version: 1.22.0
• If using SSH remote, specify OS of remote machine: Window10 64

Bug Summary and Steps to Reproduce

Bug Summary:
the language server crashes during initial workspace parsing

Steps to reproduce:
open workspace and open a cpp file

Expected behavior:
no crash

Configuration and Logs

output from "C/C++ crash call stacks":


A C/C++ extension process has crashed. The crashing process name, date/time, signal, and call stack are below -- it would be helpful to include that in a bug report at https://github.com/Microsoft/vscode-cpptools/issues.

cpptools
8/29/2024, 9:49:47 AM
SIGSEGV
msvc::translate_encoding_to_utf8(std::span<unsigned char const, 18446744073709551615ul>, msvc::buffer&, msvc::document_encoding_e, msvc::document_encoding_e*)+193
msvc::random_file_buffer::load_entire_file()+280
msvc::random_file_buffer::random_file_buffer(msvc::basic_zstring_view)+422
direct_buffer_t::direct_buffer_t(msvc::basic_zstring_view, bool)+154
edge_file_buf_t::init(msvc::basic_zstring_view, std::shared_ptr<host_buffer> const&)+247
edge_system_t::create_edge_file_buf(msvc::basic_zstring_view, std::shared_ptr<host_buffer> const&)+587
edge_system_t::find_or_create_edge_file_buf(msvc::canonicalized_file_path_t const&, snapshot::snapshot_session_t, bool)+737
edge_system_t::find_or_create_file_buffer(msvc::basic_zstring_view, snapshot::snapshot_session_t const&, msvc::buffer_kind_e)+126
edge::file_buffer::open(char const*, snapshot::snapshot_session_t, msvc::buffer_kind_e, a_canonicalized_file_name*)+303
edge::file_buffer::open(char const*, msvc::buffer_kind_e)+78
a_file_buffer_stream::create(char const*)+47
open_input_stream(char const*)+368
open_source_file(char const*, an_open_file_result*, a_unicode_source_kind*)+73
open_source_file_with_error_handling(char const*, int, an_open_file_result*, a_unicode_source_kind*)+36
…
open_file_and_push_input_stack(char const*, int, int, int, int, int, int, int, int, int*, int, int, int, char const*, char const**)+289
…
fe_init_part_2()+15
run_tag_parser()+429
process_translation_unit(char const*, int, an_exported_template_file*)+641
cfe_main(int, char**)+121
cfe_main_exception_handler(int, char**)+13
edg_main(int, char**)+13

Other Extensions

No response

Additional context

No response

[sean-mcmanus]

@tuxStarElan We have a potential fix for 1.22.1, but we haven't been able to verify our fix yet. Do you know what encoding your files are using?

[sean-mcmanus]

@tuxStarElan This might be fixed with https://github.com/microsoft/vscode-cpptools/releases/tag/v1.22.1, but we don't know for sure yet...

[Sleinmaster]

@sean-mcmanus seems to be fixed for me with version 1.22.2 (went from 1.22.0 directly to 1.22.2).

[sean-mcmanus]

@Sleinmaster Yes, I can also confirm now that it's fixed with 1.22.2 (1.22.1 had an unrelated bug that got fixed with 1.22.2).