Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable pre-release toasts #12438

Closed
rongxin-liu opened this issue Jul 5, 2024 · 11 comments
Closed

Disable pre-release toasts #12438

rongxin-liu opened this issue Jul 5, 2024 · 11 comments
Assignees
Labels
enhancement Improvement to an existing feature fixed Check the Milestone for the release in which the fix is or will be available. Language Service quick fix
Milestone

Comments

@rongxin-liu
Copy link

Feature Request

Would it be possible to have a setting that allows users to disable pre-release toasts like this one?
toast

In the educational context, many students use Codespace as their standardized online IDE. However, they rarely know what pre-release extensions would benefit them and might be distracting in most cases.

@rongxin-liu
Copy link
Author

cc @dmalan

@sean-mcmanus sean-mcmanus added Language Service help wanted Can be fixed in the public (open source) repo. enhancement Improvement to an existing feature labels Jul 5, 2024
@sean-mcmanus
Copy link
Contributor

The user would still have to set the setting though, right? Or are they getting the setting from some shared file?

We could also add a "More info" button that explains when the pre-release version should be used.

@dmalan
Copy link

dmalan commented Jul 5, 2024

In our educational use case, the student gets the setting from a common .devcontainer.json file. For instance, we set a number of C/C++ settings via key/value pairs like https://github.com/cs50/codespace/blob/44fa8e1811fddac4b9532c9582ff10c6b4a5423a/devcontainer.json#L47-L55.

Ideally, then, there'd be a similar setting via which we could suppress any prompts to switch away from the defined configuration, so that students don't stray from a standardized environment.

Thank you for considering!

@sean-mcmanus
Copy link
Contributor

@dmalan Could you elaborate on "suppress any prompts to switch away from the defined configuration"? Are you wanting the setting to be more general or apply to other scenarios or just this one?

@dmalan
Copy link

dmalan commented Jul 5, 2024

Ah, just this one, ideally to suppress this toast, so that students don't opt into pre-releases:

Screenshot 2024-07-04 at 8 05 28 PM

@sean-mcmanus sean-mcmanus removed the help wanted Can be fixed in the public (open source) repo. label Jul 5, 2024
@sean-mcmanus sean-mcmanus moved this to Pull Request in cpptools Jul 5, 2024
@sean-mcmanus sean-mcmanus added this to the 1.21.1 milestone Jul 5, 2024
@sean-mcmanus sean-mcmanus self-assigned this Jul 5, 2024
@sean-mcmanus
Copy link
Contributor

sean-mcmanus commented Jul 5, 2024

@dmalan I have a potential fix (pending review on Monday) at #12447 that just checks the extensions.ignoreRecommendations setting (which is already set to true in your devcontainer.json settings).

@dmalan
Copy link

dmalan commented Jul 6, 2024

Oh that sounds great, thanks very much!

@sean-mcmanus sean-mcmanus moved this from Pull Request to Done in cpptools Jul 10, 2024
@sean-mcmanus sean-mcmanus added the fixed Check the Milestone for the release in which the fix is or will be available. label Jul 10, 2024
@sean-mcmanus
Copy link
Contributor

@dmalan Fixed with https://github.com/microsoft/vscode-cpptools/releases/tag/v1.21.1 (although you'll have to wait till later this week for the 1.21.2 non-prerelease version).

@dmalan
Copy link

dmalan commented Jul 16, 2024

Thanks so much, @sean-mcmanus, much appreciated!

@sean-mcmanus
Copy link
Contributor

@dmalan
Copy link

dmalan commented Jul 22, 2024

Thank you, @sean-mcmanus!

@github-actions github-actions bot locked and limited conversation to collaborators Sep 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Improvement to an existing feature fixed Check the Milestone for the release in which the fix is or will be available. Language Service quick fix
Projects
Status: Done
Development

No branches or pull requests

3 participants