Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy declaration / definition results are not formatted when pasted #10956

Closed
sean-mcmanus opened this issue May 15, 2023 · 5 comments
Closed

Copy declaration / definition results are not formatted when pasted #10956

sean-mcmanus opened this issue May 15, 2023 · 5 comments
Assignees
@browntarik
Labels
bug Feature: Code Formatting Feature: Create Declaration or Definition Feature: Refactoring fixed Check the Milestone for the release in which the fix is or will be available. Language Service
Milestone
1.20.0

Comments

@sean-mcmanus
Copy link
Contributor

sean-mcmanus commented May 15, 2023 •
edited
Loading

It gives:

image

The issue doesn't repro with Create declaration / definition, in which case the formatting is applied after the creation is done.

I think the root cause of the bug is #10236 .
@sean-mcmanus sean-mcmanus added this to the 1.16.0 milestone May 15, 2023
@sean-mcmanus sean-mcmanus modified the milestones: 1.16.0, 1.16 May 15, 2023
@sean-mcmanus sean-mcmanus added the insiders Currently only repros with our latest Insiders release. label May 15, 2023
@sean-mcmanus sean-mcmanus modified the milestones: 1.16, 1.17 Jun 23, 2023
@sean-mcmanus sean-mcmanus removed the insiders Currently only repros with our latest Insiders release. label Jul 20, 2023
@michelleangela michelleangela removed this from the 1.17 milestone Aug 15, 2023
@sean-mcmanus
Copy link
Contributor Author

sean-mcmanus commented Sep 7, 2023 •
edited
Loading

This issue is reproing with (the pending/unreleased) Extract Function feature too. Well -- I'm guessing I can do the same workaround that Create Declaration / Definition does.

@sean-mcmanus
Copy link
Contributor Author

@bobbrow It feels to me like this issue isn't high enough priority for 1.19.0 compared to the other To Do stuff (unless we get more user feedback or reports of bugs caused by this), i.e. it's at the bottom of my list unless someone else wanted to investigate it.

@bobbrow
Copy link
Member

bobbrow commented Nov 7, 2023

@sean-mcmanus, sure. Should we close as a dupe of #10236? I think that maybe addressing that takes care of this one.

@sean-mcmanus
Copy link
Contributor Author

@bobbrow I'm not sure. But #10236 seems low priority too.

This was referenced Nov 14, 2023
Closed
Open
@sean-mcmanus
Copy link
Contributor Author

Fixing this issue could fix #11675 and #11673 .

@browntarik browntarik self-assigned this Dec 29, 2023
@browntarik browntarik mentioned this issue Jan 3, 2024
Closed
@browntarik browntarik mentioned this issue Mar 4, 2024
Merged
@browntarik browntarik added the fixed Check the Milestone for the release in which the fix is or will be available. label Mar 19, 2024
@sean-mcmanus sean-mcmanus added this to the 1.20.0 milestone Mar 25, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@browntarik browntarik

Labels
bug Feature: Code Formatting Feature: Create Declaration or Definition Feature: Refactoring fixed Check the Milestone for the release in which the fix is or will be available. Language Service
Projects
None yet
Milestone
1.20.0
Development

No branches or pull requests
4 participants
@bobbrow @sean-mcmanus @michelleangela @browntarik