Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMakeUserPresets regression #3956

Closed
christophe-calmejane opened this issue Aug 2, 2024 · 4 comments · Fixed by #3958
Closed

CMakeUserPresets regression #3956

christophe-calmejane opened this issue Aug 2, 2024 · 4 comments · Fixed by #3958
Assignees
Labels
bug a bug in the product regression used to work and no longer does. Regressions are typically high priority
Milestone

Comments

@christophe-calmejane
Copy link

christophe-calmejane commented Aug 2, 2024

Brief Issue Summary

CMakeUserPresets is no longer working when extending an existing configure preset.
Let's take this very short example:

CMakePresets.json file:

{
	"version": 6,
	"configurePresets": [
		{
			"name": "project",
			"binaryDir": "${sourceDir}/_build_${presetName}"
		}
	]
}

and this CMakeUserPresets.json file:

{
	"version": 6,
	"configurePresets": [
		{
			"name": "user project",
			"inherits": [
				"project"
			]
		}
	]
}

When I run cmake --list-presets I correctly get:

Available configure presets:

  "user project"
  "project"

Since a recent update of vccode-cmake-tools, I don't get my user project anymore.

As a reminder, this is taken from cmake documentation:
If CMakePresets.json and CMakeUserPresets.json are both present, CMakeUserPresets.json implicitly includes CMakePresets.json, even with no include field, in all versions of the format.

Although I did try to add an include of CMakePresets in my CMakeUserPresets file, it doesn't help.

Additional Information

I'm on v1.19.35

@github-project-automation github-project-automation bot moved this to Blocked in CMake Tools Aug 2, 2024
@github-actions github-actions bot added the triage label Aug 2, 2024
@gcampbell-msft gcampbell-msft added bug a bug in the product regression used to work and no longer does. Regressions are typically high priority and removed triage labels Aug 2, 2024
@gcampbell-msft gcampbell-msft moved this from Blocked to In Progress in CMake Tools Aug 2, 2024
@gcampbell-msft gcampbell-msft added this to the 1.19 milestone Aug 2, 2024
@gcampbell-msft
Copy link
Collaborator

gcampbell-msft commented Aug 5, 2024

Could you test this vsix?
cmake-tools.zip

This should (I believe), fix the regression.

@christophe-calmejane
Copy link
Author

It doesn't look like a vsix file, how should I install it?

@gcampbell-msft
Copy link
Collaborator

@christophe-calmejane Ah, my apologies, some people I've already given the instructions and some I haven't.

Steps:

  1. Download the file.
  2. Change the extension from .zip to .vsix (Github doesn't allow dropping of .vsix)
  3. Install manually in VSCode extensions pane:
    image

@christophe-calmejane
Copy link
Author

Oh yes sorry I didn't know that. (But I just dropped the vsix file to the extension panel and it correctly replaced my version with yours).
I can confirm it both fixes this issue, and that #3522 is also working fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug a bug in the product regression used to work and no longer does. Regressions are typically high priority
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

3 participants