environmentSetupScript exit code not checked

[joelfrederico]

Brief Issue Summary

I had an environmentSetupScript that worked. It started failing when IT removed a feature from the machine I needed. But since VSCode doesn't check the script's exit code, I never had a chance to notice that it was failing.

CMake Tools Diagnostics

No response

Debug Log

No response

Additional Information

The result of the script is here:

vscode-cmake-tools/src/kit.ts

Line 693 in 4240059

const res = await proc.execute(run_command, [], null, { shell: true, silent: true }).result; // run script

As far as I can tell, its exit code is never checked. If it was checked, and an error raised, I could have noticed that my script wasn't working properly.

[gcampbell-msft]

@joelfrederico Thanks for the call-out we should make a failure here more obvious. Adding it to the backlog.