From deecdf276d1f1287e9dea009c2a5f03010d570cf Mon Sep 17 00:00:00 2001 From: Uli Franke Date: Wed, 26 Feb 2020 15:48:54 +0100 Subject: [PATCH] Changed Serial.updatePortListStatus to make use of optional argument to eliminate updatePortListStatus(null) calls --- src/serialmonitor/serialMonitor.ts | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/serialmonitor/serialMonitor.ts b/src/serialmonitor/serialMonitor.ts index 28b58fa7..622d1855 100644 --- a/src/serialmonitor/serialMonitor.ts +++ b/src/serialmonitor/serialMonitor.ts @@ -72,11 +72,11 @@ export class SerialMonitor implements vscode.Disposable { this._baudRateStatusBar.command = "arduino.changeBaudRate"; this._baudRateStatusBar.tooltip = "Baud Rate"; this._baudRateStatusBar.text = defaultBaudRate.toString(); - this.updatePortListStatus(null); + this.updatePortListStatus(); const dc = DeviceContext.getInstance(); dc.onChangePort(() => { - this.updatePortListStatus(null); + this.updatePortListStatus(); }); } public get initialized(): boolean { @@ -210,8 +210,7 @@ export class SerialMonitor implements vscode.Disposable { } } - // TODO EW: use default value for port function parameter and change all updatePortListStatus(null) calls accordingly - private updatePortListStatus(port: string) { + private updatePortListStatus(port?: string) { const dc = DeviceContext.getInstance(); if (port) { dc.port = port;