Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ginkgo] Update to 1.6.0 #34280

Merged
merged 18 commits into from
Oct 13, 2023
Merged

[ginkgo] Update to 1.6.0 #34280

merged 18 commits into from
Oct 13, 2023

Conversation

upsj
Copy link
Contributor

@upsj upsj commented Oct 5, 2023

Based on #27792, this adds the latest version

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@upsj upsj marked this pull request as ready for review October 5, 2023 16:25
@upsj
Copy link
Contributor Author

upsj commented Oct 5, 2023

x64_uwp fails because of SDL turning deprecation warnings into errors https://stackoverflow.com/questions/55007377/deprecated-results-in-build-failure-in-vs2017-error-c4996

The other issues I cannot reproduce locally, so no idea what is going wrong there.
For now I will just disable UWP and android triplets

Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

x64_uwp fails because of SDL turning deprecation warnings into errors https://stackoverflow.com/questions/55007377/deprecated-results-in-build-failure-in-vs2017-error-c4996

You should patch the build or add /wd4996 as necessary to turn those warnings off. This change is probably fallout from WINDOWS_USE_MSBUILD.

@BillyONeal BillyONeal marked this pull request as draft October 5, 2023 19:29
@upsj
Copy link
Contributor Author

upsj commented Oct 6, 2023

@BillyONeal It makes more sense to review #27792 first, which is where most of the surprising changes originate.

@Adela0814 Adela0814 added the category:port-update The issue is with a library, which is requesting update new revision label Oct 7, 2023
@upsj upsj marked this pull request as ready for review October 8, 2023 08:31
@upsj upsj requested a review from BillyONeal October 8, 2023 08:31
@BillyONeal BillyONeal added the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label Oct 10, 2023
@BillyONeal
Copy link
Member

BillyONeal commented Oct 10, 2023

Marked vcpkg-team-review because I want a second opinion on the WINDOWS_USE_MSBUILD thing. The contributor is upstream so I'm inclined to resolve any breakage in the way they want.

@BillyONeal BillyONeal dismissed their stale review October 10, 2023 01:13

The things worth blocking over are fixed.

@BillyONeal BillyONeal removed the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label Oct 12, 2023
@upsj upsj requested a review from Adela0814 October 13, 2023 08:07
@Adela0814
Copy link
Contributor

I encountered the following error while testing all features:
Repro step: .\vcpkg.exe install ginkgo[*]:x64-windows.
Error message:

CMake Error at E:/5/vcpkg/downloads/tools/cmake-3.27.1-windows/cmake-3.27.1-windows-i386/share/cmake-3.27/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find OpenMP_C: Found unsuitable version "2.0", but required is at
  least "3.0" (found -openmp)
Call Stack (most recent call first):
  E:/5/vcpkg/downloads/tools/cmake-3.27.1-windows/cmake-3.27.1-windows-i386/share/cmake-3.27/Modules/FindPackageHandleStandardArgs.cmake:598 (_FPHSA_FAILURE_MESSAGE)
  E:/5/vcpkg/downloads/tools/cmake-3.27.1-windows/cmake-3.27.1-windows-i386/share/cmake-3.27/Modules/FindOpenMP.cmake:577 (find_package_handle_standard_args)
  E:/5/vcpkg/scripts/buildsystems/vcpkg.cmake:859 (_find_package)
  CMakeLists.txt:105 (find_package)

config-x64-windows-out.log

@upsj
Copy link
Contributor Author

upsj commented Oct 13, 2023

@Adela0814 That is expected, MSVC only supports old OpenMP versions, so we cannot support it. This already came up in the past (#16536 (comment)), but it doesn't seem possible to express what features are available on which platforms except through the descriptions.

@Adela0814 Adela0814 added the info:reviewed Pull Request changes follow basic guidelines label Oct 13, 2023
@BillyONeal
Copy link
Member

BillyONeal commented Oct 13, 2023

but it doesn't seem possible to express what features are available on which platforms except through the descriptions.

You should be able to add something like "supports": "!windows | !mingw" to the feature?

EDIT: I mean for next time

@BillyONeal BillyONeal merged commit fa4a2a7 into microsoft:master Oct 13, 2023
@BillyONeal
Copy link
Member

Thanks for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants