-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ginkgo] Update to 1.6.0 #34280
[ginkgo] Update to 1.6.0 #34280
Conversation
x64_uwp fails because of SDL turning deprecation warnings into errors https://stackoverflow.com/questions/55007377/deprecated-results-in-build-failure-in-vs2017-error-c4996 The other issues I cannot reproduce locally, so no idea what is going wrong there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
x64_uwp fails because of SDL turning deprecation warnings into errors https://stackoverflow.com/questions/55007377/deprecated-results-in-build-failure-in-vs2017-error-c4996
You should patch the build or add /wd4996 as necessary to turn those warnings off. This change is probably fallout from WINDOWS_USE_MSBUILD
.
@BillyONeal It makes more sense to review #27792 first, which is where most of the surprising changes originate. |
Marked |
The things worth blocking over are fixed.
I encountered the following error while testing all features:
|
@Adela0814 That is expected, MSVC only supports old OpenMP versions, so we cannot support it. This already came up in the past (#16536 (comment)), but it doesn't seem possible to express what features are available on which platforms except through the descriptions. |
You should be able to add something like EDIT: I mean for next time |
Thanks for the update! |
Based on #27792, this adds the latest version
./vcpkg x-add-version --all
and committing the result.