Print path to compiler in output #1328
Conversation
|
What's the underlying goal of these PRs? |
|
From PR #1320:
After the team talked about it, we felt the best path forward was to print the path to the detected compiler. |
|
Do I understand it correctly that you just want to make the user aware that the problem exists instead of fixing it by prioritising the toolset inside the developer command prompt higher than the latest Visual Studio installation? Furthermore, compiler detection doesn't work the same way on all platforms, e.g. I have GCC 11 and GCC 12 but vcpkg selects GCC 11 although I built my cmake project with GCC 12 and vcpkg is invoked through cmake. I think you should detect this kind of compiler mismatch on all platforms. |
|
Yes, the goal for this PR is to make the user aware of the problem (this was an ask by an internal customer), and leave it up to the user to select the correct compiler in the toolchain or triplet. That's a good point, and vcpkg should probably detect the compiler mismatch in your example. |
|
I see now you did have corresponding detect_compiler changes. I think you should print the version if we don't have the path for previous detect_compilers rather than printing blank. |
|
Instead, I decided to not print a message if |
src/vcpkg/commands.build.cpp
Outdated
| static constexpr StringLiteral s_path_marker = "#COMPILER_CXX_PATH#"; | ||
| if (Strings::starts_with(s, s_path_marker)) | ||
| { | ||
| compiler_info.path = s.substr(s_path_marker.size()).to_string(); |
There was a problem hiding this comment.
| compiler_info.path = s.substr(s_path_marker.size()).to_string(); | |
| const auto compiler_cxx_path = s.substr(s_path_marker.size()); | |
| compiler_info.path.assign(compiler_cxx_path.data(), compiler_cxx_path.size()); |
This extreme nitpick avoids an extra temporary string.
|
To fix the test failures you can update https://github.com/microsoft/vcpkg-tool/blob/main/vcpkg-init/vcpkg-scripts-sha.txt to include your changes there |
|
The linux failure is fixed by microsoft/vcpkg#37129 |
For each call to
detect_compiler, print the detected compiler path. Alternative to #1320