Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: namedTypes* to sharedTypes*, @shouldExport to @export or @public or @published #85

Open
imWildCat opened this issue Dec 17, 2021 · 2 comments
Open

Proposal: namedTypes* to sharedTypes*, @shouldExport to @export or @public or @published #85

imWildCat opened this issue Dec 17, 2021 · 2 comments

Comments

@imWildCat
Copy link
Contributor

Two naming suggestions.

namedTypes* to sharedTypes*

named sounds ambiguous. This kind of type is shared between different modules/files.

@shouldExport to @export or @public or @published

shouldExport looks a bit lengthy. Can we simplify it?
@zhuorantan
Copy link
Contributor

The first looks good to me. I have doubt about @export, @public though. It may be confused with TypeScript keywords.

@imWildCat
Copy link
Contributor Author

These tags would only be strings instead of identifiers in the runtime. Even if it has conflicts with TypeScript keywords, it won't affect anything?

In addition, export in TypeScript has similar meaning with @export in the context of ts-gyb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@imWildCat @zhuorantan