MSTEST0015: Test method should not be ignored shouldn't be enabled in Recommended (maybe even All)

[Youssef1313]

No description provided.

[Evangelink]

+1 for dropping from Recommended. Not sure what to do with All. In a way, it's nice to respect the semantic but it also feels like this rule is more of a "audit" kind of rule that you want to try out once in a while.

@Youssef1313 do you know what roslyn does for "all"? Is it truly all?

[Youssef1313]

@Evangelink For roslyn-analyzers, "All" is not truly all. And that's the case for MSTest today as well.

For roslyn-analyzers, they have isEnabledByDefaultInAggressiveMode (which is commonly set to false for rules that are marked CandidateForRemoval, but it's not limited to CandidateForRemoval).

For us, we already disable the "conflicting" rules (Dispose vs Cleanup and ctor vs Init) in "All" mode. I named the flag as disableInAllMode as I found the name more clear than isEnabledByDefaultInAggressiveMode

[Evangelink]

Yes I saw that part and conflicting rules do make sense to be disabled (or to have a side selected). I think the ignore is hitting yet another space. I feel like we should start with it disabled and monitor usages, if we see many people enabling it then we can change this decision.