Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_IncludeGenerateTestingPlatformEntryPointIntoCompilation target is suspect #4775

Closed
Youssef1313 opened this issue Jan 24, 2025 · 0 comments · Fixed by #4777
Closed

_IncludeGenerateTestingPlatformEntryPointIntoCompilation target is suspect #4775

Youssef1313 opened this issue Jan 24, 2025 · 0 comments · Fixed by #4777

Comments

@Youssef1313
Copy link
Member

Youssef1313 commented Jan 24, 2025

  • Using BeforeTargets="CoreCompile", in my experience, is buggy in most cases. We need to verify, but in many cases such targets end up running after _GenerateCompileDependencyCache so they are not included in the hash. This can cause weird incremental build issues. Usually BeforeCompile is a better hook. See [Bug]: Input file "*.CoreCompileInputs.cache" is newer than output file "*.pdb" dotnet/msbuild#8807 for example of the kind of issue this can cause.
  • We should also consider running it before XamlPreCompile (important for WinUI), and potentially provide an extensibility so that people with special infrastructure can run the target earlier per their requirements.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant