Correct position on startup when window is out of screen

[dynahcatq]

Summary of the Pull Request

If the terminal window appears to be off-screen at startup or appears to be partially behind the task bar, reset its position to the top left corner of the screen. Manually tested by giving

References

#4681

PR Checklist

• Closes Terminal startup location partially off Desktop #3187
• CLA signed. If not, go over here and sign the CLA
• I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: Terminal startup location partially off Desktop #3187

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

This will reset the window to top-left because the window is partially behind the taskbar:

This will reset the window to top-left because the left side of the window is off the screen:

This will reset the window to top-left because the window is partially off the screen:

For multi-monitor:

Note that this will also reset the window to top-left because the window can fit in a single screen but the window is outside of the screen's work area:

This will reset the window to top-left because the window can fit in a single screen but the window is outside of the screen's work area:

This will reset the window to top-left because the window is partially off the screen:

Note that this will NOT reset the window position to top-left because the window is entirely visible.

[DHowett-MSFT]

Whoops, sorry about that! I didn't get a notification when this was marked ready for review. Tsk, github!

Our hatches are battened for v1, so we may be in a bit of a time crunch, but we'll review this as soon as we can.

[jsoref]

What happens if multiple windows are (partially) offscreen at startup? (or is that not possible?)
--I'd prefer a "cascaded windows".

[dynahcatq]

@jsoref I think all the window should all be top-left, because if we do a cascaded windows, it is possible that some of the windows will be pushed offscreen if there are many windows at startup.

[jsoref]

Classically, Windows had a strategy for that cascade overflow which handled that by staggering to another location (it was fun playing with this ...)

[dynahcatq]

Oh that would make sense then, thanks for mentioning the cascade overflow handler, gotta try it out.

[ekoschik]

perhaps it'd be better to GetMonitorInfo(MonitorFromWindow()) and check each side of the proposed rect with the work area edge (nudging back onscreen).

[zadjii-msft]

Woah hey there @dynahcatq - I dunno what happened. This must have gotten lost in the crunch for //Build last year. Jeez, that feels bad. Would you still be interested in merging this in? There's probably a decent amount of merge conflicts - sorry about that. If not, then I can always drive another PR with the same changelist.

Sorry again!

[ghost]

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.