Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the VT parser's parse state into instanced storage #3110

Merged
merged 2 commits into from
Oct 9, 2019
Merged

Move the VT parser's parse state into instanced storage #3110

merged 2 commits into from
Oct 9, 2019

Conversation

DHowett-MSFT
Copy link
Contributor

Summary of the Pull Request

It was bad before, but now it is not.

References

PR Checklist

@DHowett-MSFT DHowett-MSFT requested a review from miniksa October 8, 2019 01:39
@DHowett-MSFT
Copy link
Contributor Author

This is, in theory, a testable bug.

@DHowett-MSFT
Copy link
Contributor Author

This is, in practice, a testable bug.

@DHowett-MSFT DHowett-MSFT mentioned this pull request Oct 8, 2019
Closed
miniksa
miniksa approved these changes Oct 8, 2019
View reviewed changes
Copy link
Member

@miniksa miniksa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff. Nice catch. Consider the C4640 thing though like we talked about if that doesn't cause trouble elsewhere.

@DHowett
Copy link
Member

DHowett commented Oct 8, 2019

followup: tried 4640, doesn't trigger. Seems to be related to static lifetime things in functions with non-trivial constructors.

@DHowett-MSFT
Copy link
Contributor Author

The VT parser used to be keeping a boolean used to determine whether it
was in bulk or single-character parse mode in a function-level static.
That turned out to not be great.

Fixes #3108; fixes #3073.

@DHowett-MSFT
Copy link
Contributor Author

WHAT. I typed that into the squash/merge box ...

@DHowett-MSFT DHowett-MSFT merged commit dd2fbef into master Oct 9, 2019
@DHowett-MSFT DHowett-MSFT deleted the dev/duhowett/vtparse branch October 9, 2019 18:01
DHowett-MSFT pushed a commit that referenced this pull request Oct 17, 2019
@DHowett
Move the VT parser's parse state into instanced storage (#3110)
361e773 
The VT parser used to be keeping a boolean used to determine whether it
was in bulk or single-character parse mode in a function-level static.
That turned out to not be great.

Fixes #3108; fixes #3073.

(cherry picked from commit dd2fbef)
@ghost
Copy link

ghost commented Oct 23, 2019

🎉Windows Terminal Preview v0.6.2951.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Oct 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-zamora carlos-zamora carlos-zamora approved these changes

@miniksa miniksa miniksa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VT parser's "should process character by character" flag is a singleton
4 participants
@DHowett-MSFT @DHowett @carlos-zamora @miniksa