Draft spec for adding profiles to the Windows jumplist #1357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
zadjii-msft
reviewed
Jul 1, 2019
There was a problem hiding this comment.
So far I'm happy with this.
- I'm happy you call out what happens if a non-existent profile is launched, I was curious.
- This seems like it's fundamentally blocked on Feature Request: wt.exe supports command line arguments (profile, command, directory, etc.) #607, so I guess we'll have to drive that one sooner than later
- As far as "Should it open a new instance of the terminal or open in a new tab?" - I'm pretty sure a new window is the only option that's going to be feasible for a while
|
Thanks for the feedback! I'll leave this PR as a draft until progress is made on 607 |
3 tasks
|
Hey @dsafa, sorry for the relative radio silence on this PR. With #3495 in review now, and an implementation in progress, I think we're much closer to being able to land this. Do you want to update this spec to reflect the proposed work in #3495? If you're too busy now (it's been 5 months and I know life can change a lot in that time 😝), we'd be happy to revive this ourselves. Thanks! |
5 tasks
|
No worries :) Unfortunately, I don't have time to help with this so I'll be happy to pass it onto the team or anyone who wants to work on it. Some things I would update or take another look at
Thanks |
zadjii-msft
added a commit
that referenced
this pull request
Jan 15, 2020
## Summary of the Pull Request This is the spec for adding commandline arguments to the Windows Terminal. This includes design work for a powerful future version of the commandline args for the Terminal, as well as a way that system could be implemented during 1.0 to provide basic functionality, while creating commandlines that will work without modification in (a future Windows Terminal version). ## References Referenced in the course of this spec: * #607 Feature Request: wt.exe supports command line arguments (profile, command, directory, etc.) * #1060 Add "open Windows terminal here" into right-click context menu * #576 Feature Request: Task Bar jumplist should show items from profile * #1357 Draft spec for adding profiles to the Windows jumplist * #2080 Spec for tab tear off and default app * #632 [Question] Configuring Windows Terminal profile to always launch elevated * #2068 New window key binding not working ## PR Checklist * [x] Specs #607 * [x] I work here * [x] _it's a spec_ ## Detailed Description of the Pull Request / Additional comments Read the spec. ----------------------------------------------------- * Let's commit this bewfore I go hog-wild on new-window * new-window vs new-tab discussion * Well, this is ready for a review * -P -> -% for --percent * Big note on powershell of course, powershell has to use `;` as the command seperator * Minor typos * This is a lot of feedback from PR bigly, it's focus-pane and focus-tab * Add notes on implementation, based on investigation * Apply suggestions from @miniksa * some updates after actually implementing the thing * some minor things from PR * Apply suggestions from code review Co-Authored-By: Dustin L. Howett (MSFT) <duhowett@microsoft.com> * comments from dustin's latest review * more comments from dustin * mostly just typos Co-authored-by: Dustin L. Howett (MSFT) <duhowett@microsoft.com>
ghost
pushed a commit
that referenced
this pull request
Jan 27, 2020
## Summary of the Pull Request Adds support for commandline arguments to the Windows Terminal, in accordance with the spec in #3495 ## References * Original issue: #607 * Original spec: #3495 ## PR Checklist * [x] Closes #607 * [x] I work here * [x] Tests added/passed * [ ] We should probably add some docs on these commands * [x] The spec (#3495) needs to be merged first! ## Detailed Description of the Pull Request / Additional comments 🛑 **STOP** 🛑 - have you read #3495 yet? If you haven't, go do that now. This PR adds support for three initial sub-commands to the `wt.exe` application: * `new-tab`: Used to create a new tab. * `split-pane`: Used to create a new split. * `focus-tab`: Moves focus to another tab. These commands are largely POC to prove that the commandlines work. They're not totally finished, but they work well enough. Follow up work items will be filed to track adding support for additional parameters and subcommands Important scenarios added: * `wt -d .`: Open a new wt instance in the current working directory #878 * `wt -p <profile name>`: Create a wt instance running the given profile, to unblock #576, #1357, #2339 * `wt ; new-tab ; split-pane -V`: Launch the terminal with multiple tabs, splits, to unblock #756 ## Validation Steps Performed * Ran tests * Played with it a bunch
4 tasks
DHowett-MSFT
pushed a commit
that referenced
this pull request
Apr 14, 2020
_This is literally just #1357, but moved to the `drafts/` folder_. Since @dsafa doesn't have the time to finish this on their own, we'll take it from here for 2.0☺️ ## Summary of the Pull Request Adds a spec describing jumplist integration and adding profiles to the jumplist. Includes details about previous investigations into adding the jumplist. ## PR Checklist * [x] Specs #576 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [n/a] Tests added/passed * [x] Requires documentation to be updated * [x] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #576 ## Detailed Description of the Pull Request / Additional comments Details in the spec. ## Validation Steps Performed N/A Co-authored-by: Brandon Chong <brndnchong@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Adds a spec describing jumplist integration and adding profiles to the jumplist. Includes details about previous investigations into adding the jumplist.
References
PR Checklist
Detailed Description of the Pull Request / Additional comments
Details in the spec.
Validation Steps Performed
N/A