Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Title bar has blurry buttons #7577

Open
ghost opened this issue Sep 9, 2020 · 15 comments
Open

Title bar has blurry buttons #7577

ghost opened this issue Sep 9, 2020 · 15 comments
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Milestone
Backlog

Comments

@ghost
Copy link

ghost commented Sep 9, 2020 •
edited by DHowett
Loading

IMO, the titlebar buttons of wt are not crisp, instead they look a bit fuzzy/blurry (atleast on my laptop).

Tested both on Intel HD 630 (screenshots in op) and Nvidia GTX 1050 (screenshot below) -
Screenshot (452)

I see the (somewhat) melting text bug in 2x magnification and above (on both nvidia and intel).
2x Magnification
2x
4x Magnification
4x

(Without using the magnify tool, the text in wt looks good enough, so I can't tell if the melting text bug is present or not, however at 2x magnification and above, the text doesn't look so good, idk if that is expected or not.)
@ghost ghost added Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Sep 9, 2020
@DHowett
Copy link
Member

DHowett commented Sep 9, 2020

We don't actually put those there -- so this is weird.

What graphics card are you using? This looks suspiciously similar to the "melting text" bug #5759.

@DHowett DHowett added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Sep 9, 2020
@ghost
Copy link
Author

ghost commented Sep 10, 2020 •
edited by DHowett
Loading

content copied to OP Tested both on Intel HD 630 (screenshots in op) and Nvidia GTX 1050 (screenshot below) - ![Screenshot (452)](https://user-images.githubusercontent.com/71010204/92683137-bd2c8980-f34f-11ea-81b9-21e60844d5f8.png)

I see the (somewhat) melting text bug in 2x magnification and above (on both nvidia and intel).
2x Magnification
2x
4x Magnification
4x

(Without using the magnify tool, the text in wt looks good enough, so I can't tell if the melting text bug is present or not, however at 2x magnification and above, the text doesn't look so good, idk if that is expected or not.)

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Sep 10, 2020
@ghost ghost changed the title Disable titlebar button shadow (Somewhat) Melting Text and Title Bar Icons (Both on Intel and Nvidia) Sep 10, 2020
@ghost ghost changed the title (Somewhat) Melting Text and Title Bar Icons (Both on Intel and Nvidia) (Somewhat) Melting Text and Title Bar Buttons (Both on Intel and Nvidia) Sep 10, 2020
@LuanVSO
Copy link
Contributor

LuanVSO commented Sep 11, 2020 •
edited
Loading

the magnifier applies smoothing to text and images by default, can you go to settings > ease of access> magnifier and unheck this option:
image
and see if the results are better for you

@ghost
Copy link
Author

ghost commented Sep 12, 2020

@LuanVSO thank you. that fixes the melting effect.

@DHowett
However, the title bar icons are still somewhat blurry at no magnification, while they look great when magnified.

Original -
1x

2x -
2x

@ghost ghost changed the title (Somewhat) Melting Text and Title Bar Buttons (Both on Intel and Nvidia) Title bar has blurry icons Sep 12, 2020
@ghost ghost changed the title Title bar has blurry icons Title bar has blurry buttons Sep 12, 2020
@zadjii-msft
Copy link
Member

@axcadsd What display scaling are you running at?

image

@zadjii-msft zadjii-msft added Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Attention The core contributors need to come back around and look at this ASAP. labels Oct 1, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Oct 1, 2020
@ghost
Copy link
Author

ghost commented Oct 1, 2020

@zadjii-msft I use 140% scaling.

@zadjii-msft
Copy link
Member

Out of curiosity, does the problem go away if you use 125% or 150%?

@zadjii-msft zadjii-msft added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Oct 1, 2020
@ghost
Copy link
Author

ghost commented Oct 2, 2020

100%
100

125%
125

140%
140

150%
150

175%
175

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Oct 2, 2020
@zadjii-msft
Copy link
Member

zadjii-msft commented Oct 9, 2020 •
edited
Loading

Welp, I'm officially out of ideas as to what might cause this. Especially annoying that we're not sure exactly what about your hardware is causing this blurriness/shadow.

I'm going to leave this open for now, and hope that we can get more community engagement and pin down what about the hardware specifically is causing this.

I wonder if it's happening to all buttons with Path icons in them. @LuanVSO does the close button on the TabView in the Xaml Controls Gallery app also have the same blurriness?

@zadjii-msft zadjii-msft removed the Needs-Attention The core contributors need to come back around and look at this ASAP. label Oct 9, 2020
@zadjii-msft zadjii-msft added Needs-Repro We can't figure out how to make this happen. Please help find a simplified repro. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Oct 9, 2020
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone Oct 9, 2020
@LuanVSO
Copy link
Contributor

LuanVSO commented Oct 9, 2020 •
edited
Loading

image
🤔
EDIT: I'm on 100% scaling btw

@zadjii-msft
Copy link
Member

what the dang heck

Maybe it's a XAML Islands bug then?

@dlong11
Copy link

dlong11 commented Oct 23, 2020

@zadjii-msft Try adding UseLayoutRounding="True" to the StackPanel. I didn't try this but I think that will fix this.

@zadjii-msft
Copy link
Member

Blech, I finally got around to trying UseLayoutRounding, but it didn't seem to make a difference. Both this and #7111 seem closely related.

@zadjii-msft zadjii-msft added Help Wanted We encourage anyone to jump in on these. and removed Needs-Repro We can't figure out how to make this happen. Please help find a simplified repro. labels Mar 26, 2021
@ghost
Copy link

ghost commented May 28, 2021

There's an issue that tracks this in the WinUI repo: microsoft/microsoft-ui-xaml/issues/4116

@moxwel
Copy link

moxwel commented Jul 13, 2021

I'm looking forward to this to get fixed. It's very strange those icons are blurred, but in other programs that doesn't occur.

I'm supposing but... Maybe is something related to an SVG? Like.... The source of the icon? Or something like that.

@zadjii-msft zadjii-msft modified the milestones: Terminal Backlog, Backlog Jan 4, 2022
@zadjii-msft zadjii-msft mentioned this issue Jun 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
6 participants
@DHowett @dlong11 @zadjii-msft @LuanVSO @moxwel and others