Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make index in closeOtherTabs and closeTabsAfter optional #7387

Closed
carlos-zamora opened this issue Aug 25, 2020 · 3 comments
Closed

Make index in closeOtherTabs and closeTabsAfter optional #7387

carlos-zamora opened this issue Aug 25, 2020 · 3 comments
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@carlos-zamora
Copy link
Member

Description of the new feature/enhancement

closeOtherTabs and closeTabsAfter both require index as an action argument.

It'd be neat if we could make index optional. And if it is not defined, we just use the currently focused tab's index.

We should probably be sure to update GenerateName() appropriately for when there is no index provided.
@carlos-zamora carlos-zamora added Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. labels Aug 25, 2020
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Aug 25, 2020
@carlos-zamora carlos-zamora mentioned this issue Aug 25, 2020
Merged
5 tasks
@ghost ghost added the In-PR This issue has a related PR label Aug 25, 2020
@zadjii-msft
Copy link
Member

/dup #7181

@ghost
Copy link

ghost commented Aug 25, 2020

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Aug 25, 2020
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting In-PR This issue has a related PR labels Aug 25, 2020
@carlos-zamora
Copy link
Member Author

of course it's a dup... Sorry!

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@carlos-zamora @zadjii-msft