Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more warning dialog settings #7094

Closed
Chips1234 opened this issue Jul 27, 2020 · 3 comments
Closed

Add more warning dialog settings #7094

Chips1234 opened this issue Jul 27, 2020 · 3 comments
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@Chips1234
Copy link
Contributor

Chips1234 commented Jul 27, 2020 •
edited
Loading

Description of the new feature/enhancement

Note: copied/split from @zadjii-msft's #6549 (comment)

Add a new setting boolean, alwaysWarnCloseWindow with default as false.

Proposed technical implementation details (optional)

Add a global setting to always warn the user when closing the window instead of only when there are multiple tabs (and in the future, warn multiple clients in panes (#6549), and warn multiple panes in when closing tab(#7077))

If possible, I would like to implement this.
@Chips1234 Chips1234 added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Jul 27, 2020
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 27, 2020
@Chips1234 Chips1234 changed the title Add more warning options Add more warning dialog settings Jul 27, 2020
@Chips1234
Copy link
Contributor Author

Ooh, actually this is a duplicate of #2976. Sorry

@DHowett
Copy link
Member

DHowett commented Jul 28, 2020

/dup #2976
thanks!

@ghost
Copy link

ghost commented Jul 28, 2020

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DHowett @Chips1234