Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The explorer context menu should only appear on shift+click #6113

Open
zadjii-msft opened this issue May 21, 2020 · 3 comments
Open

The explorer context menu should only appear on shift+click #6113

zadjii-msft opened this issue May 21, 2020 · 3 comments
Labels
Area-ShellExtension For issues related to the explorer right-click context menu Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Milestone

Comments

@zadjii-msft
Copy link
Member

Follow-up from #6100.

The Explorer context menu is notoriously cluttered. We shouldn't add to that clutter if we can avoid it. This issue represents me taking the time to investigate how exactly to make the menu only appear on shift+right click, not just right click.

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels May 21, 2020
@zadjii-msft zadjii-msft added Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. labels May 21, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label May 21, 2020
@zadjii-msft zadjii-msft added this to the Terminal v2.0 milestone May 21, 2020
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label May 21, 2020
@zadjii-msft zadjii-msft added Area-ShellExtension For issues related to the explorer right-click context menu and removed Area-UserInterface Issues pertaining to the user interface of the Console or Terminal labels May 28, 2020
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label May 28, 2020
@zadjii-msft
Copy link
Member Author

zadjii-msft commented Jun 1, 2020

Alright so we took a quick peek through the code and we're not sure exactly how to do this. Fortunately, PowerToys does seem to do something similar:

https://github.com/microsoft/PowerToys/blob/d16ebba9e0f06e7a0d41d981aeb1fd0a78192dc0/src/modules/powerrename/dll/PowerRenameExt.cpp#L60-L110

Looks like they implement another interface, IContextMenu. If someone in the community was passionate about decluttering the context menu, we'd definitely appreciate a similar PR 😄

EDIT: As mentioned in an offline thread:

You should stick to the IExplorerCommand implementation and avoid IContextMenu if possible.

and also mentioned here:

If you return ECS_HIDDEN as a function of the keyboard state (if (GetKeyState(VK_SHIFT) < 0) or GetAsyncKeyState(), read the docs on both, I'm not sure which is the right one to use in this case) this can be hidden conditionally. This depends on the shell calling your handler coincident with presenting the UI. I think that is always true but might not always be. Pay attention to this issue and lets discuss with the File Explorer owners.

@zadjii-msft zadjii-msft added the Help Wanted We encourage anyone to jump in on these. label Jun 1, 2020
@miniksa miniksa added Area-ShellExtension For issues related to the explorer right-click context menu and removed Area-ShellExtension For issues related to the explorer right-click context menu labels Jun 19, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jun 19, 2020
@rescenic
Copy link

Yeah, it's ugly long name. I am trying to disable that context menu. But I can't find Windows Terminal Preview context menu item using Nirsoft tools, like ShellExView and ShellMenuView.
img

@igorakkerman
Copy link

Please make this configurable, Terminal is a core application in my work and should not be a secondary function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-ShellExtension For issues related to the explorer right-click context menu Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants