Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ligatures unexpected/wrong #5923

Closed
xasx opened this issue May 15, 2020 · 6 comments
Closed

Ligatures unexpected/wrong #5923

xasx opened this issue May 15, 2020 · 6 comments
Labels
Needs-Tag-Fix Doesn't match tag requirements Resolution-External For issues that are outside this codebase

Comments

@xasx
Copy link

xasx commented May 15, 2020

Environment

Windows build number: 10.0.18363.0
Windows Terminal version: 0.11.1333.0

Font: Inconsolata NF

Steps to reproduce

Run a Shell. It is sufficient that it outputs the string fi somewhere. Fish seems predestined therefore 😉

Expected behavior

"fi" is rendered as readable letter combo F-I since this string is a substring of many words.

Actual behavior

"fi" becomes a telephone symbol. ☎️

Screenshots

WSL/fedoraremix/fish

image

Windows/PWSH 7

image
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels May 15, 2020
@DHowett-MSFT
Copy link
Contributor

Absolutely fascinating. I can't find "Inconsolata NF", I can only find LGC and Go variants. Can you share a link to the actual font you're using?

I recall seeing this before, but I can't find the issue.

@DHowett-MSFT
Copy link
Contributor

Er, found the font.

@DHowett-MSFT
Copy link
Contributor

DHowett-MSFT commented May 15, 2020 •
edited
Loading

I've got some bad news!

This is just how that font is authored. I know that sounds crazy, but here's what an impartial open-source font editing suite suggests:

image

image

@DHowett-MSFT DHowett-MSFT added Resolution-External For issues that are outside this codebase and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels May 15, 2020
@DHowett-MSFT
Copy link
Contributor

image

@j4james
Copy link
Collaborator

j4james commented May 17, 2020

For the record, I think it's the Nerd Fonts patcher that is to blame. The original font probably had one or more ligatures stored in the private use area, and those glyphs got overwritten when the patcher used the same code points for the Nerd Fonts icons. See the bug report here: ryanoasis/nerd-fonts#254 (comment)

@xasx
Copy link
Author

xasx commented May 19, 2020

@DHowett-MSFT thanks for investigating.

@j4james thanks for sorting. So: Happens to all NFs with fi/fl ligatures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs-Tag-Fix Doesn't match tag requirements Resolution-External For issues that are outside this codebase
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@xasx @j4james @DHowett-MSFT