-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kubernetes helm symbol ⎈ (U+2388) is too small #5893
Comments
I agree. I hate to call others out, but these Nerd Fonts are stomping all over the "unicode private use area" and expecting everybody to, well, treat them the same way. Those areas are "private use" for a reason :/ EDIT: So, 2588 is absolutely not in the PUA. I'm sorry about that. Read below for more details on why we think this is "hard" 😄 |
To be fair, I don't think this has anything to do with Nerd Fonts. The symbol is coming straight from Fira Code, unless I'm missing something. As I linked to above, the Fira Code font has defined the symbol as double width. Shouldn't that be respected? |
Ah, it's also fair that 2588 isn't IN the PUA. Sorry about that. So, this comes up a lot. It's... not pleasant. Applications connected to the client side of a console (or terminal!) need to be able to do column-counting. To do so, most of them either use inbuilt character tables or something like Unfortunately, there's no requirement that a character be presented. Anywhere! Subsequently, there's no affordance in |
That makes sense. Thanks for the clarification! |
Sorry -- consider this a ramble. You're not required to read it 😄 Consider the case of Kubernetes sitting at the remote end of an SSH session. Say something prints the ⎈ symbol and wants to determine how much space is left in the line... It's over SSH, and very far removed from the presentation surface that might be making the decision on how big it is. That's not a tenable position for it to be in, because it can't make that space determination without information known only to the application sitting on the other end of its PTY. Even if we, and the rest of the text-mode community, plumbed through support for glyph presentation impacting width, who would answer that question?
Any determination would have to make it through all of those layers and back down, synchronously, when the K8s CLI asks how big a glyph is. This is a hot button topic over on the terminal working group tracker! 😁 |
Environment
Steps to reproduce
Compare the Kubernetes helm symbol ⎈ (U+2388) in Visual Studio Code & Windows Terminal.
Expected behavior
The symbol should be double width.
Actual behavior
The symbol is displayed using single width and is too small.
Visual Studio Code:
![image](https://user-images.githubusercontent.com/750121/81863573-8de35700-95bf-11ea-9f36-92b86bb761cd.png)
Windows Terminal:
![image](https://user-images.githubusercontent.com/750121/81863708-bc613200-95bf-11ea-8643-7dc35ff0e4d3.png)
The text was updated successfully, but these errors were encountered: