Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for touchscreen selection #5159

Open
moetayuko opened this issue Mar 28, 2020 · 9 comments
Open

Add support for touchscreen selection #5159

moetayuko opened this issue Mar 28, 2020 · 9 comments
Assignees
Labels
Area-Input Related to input processing (key presses, mouse, etc.) Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Milestone

Comments

@moetayuko
Copy link

moetayuko commented Mar 28, 2020

Description of the new feature/enhancement

I'm a Surface pro user and sometimes need to use CLI tools without bothering to pick up the keyboard (although it's a mess to type with on-screen keyboard), but it turns out that Windows Terminal is not optimized for touchscreen at all.

Proposed technical implementation details (optional)

As far as I can tell, the following need to be implemented:

  1. Automatically popup on-screen keyboard and resize the window to fit it on touch.
  2. Long press to select/copy/paste.
  3. Zoom with finger gestures (Touch Zoom with two fingers don't work on Touch screen (but it works on Touch Pad) #3149)
@moetayuko moetayuko added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Mar 28, 2020
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Mar 28, 2020
@Nyameliaaaa

This comment has been minimized.

@DHowett-MSFT

This comment has been minimized.

@Nyameliaaaa

This comment has been minimized.

@zadjii-msft
Copy link
Member

@diligamer Ah yes, but some developers do use touchscreens, so we shouldn't discount the opinion of a minority of users based solely on the fact that they're a minority.


Back on topic, I could have sworn that @leonMSFT actually already implemented having the on-screen keyboard appear when you tap on the Terminal. @dianlujitao what verison of the Terminal are you using?

I'm fine with leaving this open to track "Long press to select/copy/paste.", since

@zadjii-msft zadjii-msft added Area-Input Related to input processing (key presses, mouse, etc.) Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels Mar 30, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Mar 30, 2020
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone Mar 30, 2020
@zadjii-msft zadjii-msft changed the title Feature Request: Touchscreen support Add support for touchscreen selection Mar 30, 2020
@leonMSFT
Copy link
Contributor

The on-screen keyboard still seems to work as of ver. 0.11.842 on my surface book when i detach my screen FYI!

@j4james
Copy link
Collaborator

j4james commented Mar 30, 2020

The on-screen keyboard still seems to work as of ver. 0.11.842 on my surface book when i detach my screen FYI!

Yes! That works for me too. I would have thought just turning on tablet mode might be enough, but this is OK.

However, even with the screen detached, I can't get touch to work for mouse click operations. For example, when using the Linux dialog utility, it doesn't seem to register taps on the dialog buttons.

@moetayuko
Copy link
Author

Yes, can confirm that on-screen keyboard works after turning on tablet mode as @j4james mentioned

@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Apr 3, 2020
@carlos-zamora carlos-zamora self-assigned this May 12, 2020
@FranckPachot
Copy link

touch screen should just act like mouse. Here is, for an example, tmux default mouse actions:

bind-key    -T copy-mode    MouseDown1Pane        select-pane
bind-key    -T copy-mode    MouseDrag1Pane        select-pane \; send-keys -X begin-selection                                               bind-key    -T copy-mode    MouseDragEnd1Pane     send-keys -X copy-selection-and-cancel
bind-key    -T copy-mode    WheelUpPane           select-pane \; send-keys -X -N 5 scroll-up
bind-key    -T copy-mode    WheelDownPane         select-pane \; send-keys -X -N 5 scroll-down
bind-key    -T copy-mode    DoubleClick1Pane      select-pane \; send-keys -X select-word
bind-key    -T copy-mode    TripleClick1Pane      select-pane \; send-keys -X select-line

I suppose all that should by supported from touchscreen

@zadjii-msft zadjii-msft modified the milestones: Terminal v2.0, 22H2 Jan 4, 2022
@zadjii-msft zadjii-msft modified the milestones: 22H2, Backlog Jul 5, 2023
@blauvster
Copy link

This really kills using Textual or any other touch oriented console application.
Textual looks great in WT and works as expected with a mouse, but since it doesn't support touch I will be switching back to conhost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Input Related to input processing (key presses, mouse, etc.) Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

9 participants