-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor artifacts on characters when using custom display scaling (like 130%) #4591
Comments
Note that the old console measures font sizes in pixels, not points (see issue #142). So that's why the sizes are so different. I'm not sure about the font rendering artifacts - even zoomed in they look almost identical to me - but I'm probably just not a good judge of quality. Also there are definitely jpeg rendering artifacts. Your original image may have been a lossless PNG, but the github-hosted images are JPEG. |
@j4james good catch. please see original uncompressed PNG there a lot of artifacts. for example see the second line, first |
The new image still seems to be a jpeg, but now that I know where to look, I can definitely see what you mean about the artifacts. I wonder if it might be related to your graphics driver. I believe the old console uses GDI for rendering, while the new Windows Terminal uses DirectX, which would explain why you only see the issue in WT. That's just a wild guess though. |
dxgiag sees no problems. you can try to reproduce this by setting custom scaling on Windows at 130% and rebooting. |
I believe this is a /dupe of #4367. Agree? |
Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report! |
@DHowett-MSFT Just to be clear, it's not a problem with the character heights - there are little rendering glitches to the right of some of the letters. I don't know if that makes it different from #4367 or not. If you zoom in, it becomes more obvious where the problems are. For example, look at the little bump on the side of the second 'o' in 'Corporation' compared to the first 'o'. I haven't been able to reproduce it myself though. |
huh |
I definitely see a repro of this with 130% scaling, font size 9, grayscale or cleartype AA, "Fira Code" as my font. Also repros at size 9 with "Hack" and "Cascadia Code" When it repros for me, it's happening in the following columns:
It's not always a left-right artifact though. Sometimes it definitely does something weird in the y direction, making some parts of characters look too wide. It kinda looks like an anti-aliasing artifact |
…ally fix the problem unfortunately. See #4591
Until I had this problem i underestimated the importance of a clean font rendering. The problem is so bad on my side that I can not concentrate when using the terminal...and i swear i don't suffer from OCD. The glitches are not minor. The lines are deformed both in height and width. For sample pictures look at #8533 (sorry for the duplicate, i searched for it and i found only a bug in which they were referring to a problem with intel cards and acceleration but that wasn't my case) |
Found same issue happening on Windows Terminal window for Ubuntu at font 12, 'JetBrains Mono' on Version: 1.9.1942.0. My screen scaling is set to 110%. Any type of anti-aliasing other than default "Grayscale" gets even worse. Check the ticked text and compare that to usual text: |
This is the zoomed view. Zooming out makes me feel like I am using a 640x480 pixel display. |
We're not? I'm simply combining threads reporting the same issue to a single thread, for easy tracking. Custom display scaling sizes, like 130%, or 118% cause a LOT of visual artifacts, that we're using this thread to track resolving. @kXborg From the settings you sent me in #11679, you have text antialiasing turned off: {
"altGrAliasing": true,
"antialiasingMode": "aliased",
"colorScheme": "Campbell Powershell",
"commandline": "powershell.exe",
"font":
{
"face": "Courier New"
},
"guid": "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}",
"hidden": false,
"name": "Windows PowerShell"
}, Getting rid of the |
@zadjii-msft, |
Environment
Microsoft Windows NT 10.0.18362.0
Windows Terminal (Preview)
Version: 0.9.433.0
Steps to reproduce
Expected behavior
fonts are scaled together with the rest of the system
Actual behavior
fonts are scaled weirdly with wrong size and visible artefacts
compare those screenshots.
font rendering has visible artifacts on almost all letters, very notable on
щ
,й
,з
,б
,р
,ч
and even Englisha
ande
. the screenshot is a lossless PNG, that's how Windows Terminal display those in real life.The text was updated successfully, but these errors were encountered: