Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font rendering issue; characters appear at wrong size, position #4367

Closed
tuscen opened this issue Jan 27, 2020 · 6 comments
Closed

Font rendering issue; characters appear at wrong size, position #4367

tuscen opened this issue Jan 27, 2020 · 6 comments
Labels
Area-Fonts Related to the font Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Resolution-No-Repro We couldn't get this to happen, or it stopped happening entirely.
Milestone

Comments

@tuscen
Copy link

tuscen commented Jan 27, 2020

Environment

Windows build number: 10.0.18363.0
Windows Terminal version (if applicable): 0.8.10091.0

Font: JetBrains Mono

Steps to reproduce

Sometimes font doesn't render properly: some characters are too tall or too short. Sometimes it's numbers, sometimes it's capital case letters. Regular conhost window or ConEmu don't have this problem.

Expected behavior

Font characters render properly.

ConEmu example. Everything seems to render properly.

conemu

conemu

Actual behavior

Some characters are too tall or too short. You can see it in capital case letters.

Аннотация 2020-01-27 154648

terminal

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jan 27, 2020
@zadjii-msft
Copy link
Member

This might be related to #610, but this seems subtle enough that it might not be. I'm going to leave this open to make sure we address this particular issue.

@zadjii-msft zadjii-msft added Area-Fonts Related to the font Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Issue-Bug It either shouldn't be doing this or needs an investigation. labels Jan 27, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jan 27, 2020
@zadjii-msft zadjii-msft added this to the Terminal v1.0 milestone Jan 27, 2020
@cinnamon-msft cinnamon-msft added v1-Scrubbed and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jan 28, 2020
@hnakamur
Copy link

I have the same issue for Japanese characters.
I created a gist to reproduce the problem https://gist.github.com/hnakamur/2a123ce7bdc0d7e5070218c258f990a8
I also added some screenshots there.

You can run the following command in a Ubuntu (Windows Subsystem for Linux) shell.

curl -sS https://gist.githubusercontent.com/hnakamur/2a123ce7bdc0d7e5070218c258f990a8/raw/b3cd604b6f8b0781cd51758afa3e1dd264e7c6d7/swap-myth.txt

@DHowett-MSFT DHowett-MSFT changed the title Font rendering issue Font rendering issue; characters appear at wrong size, position Feb 18, 2020
@cinnamon-msft cinnamon-msft added Priority-2 A description (P2) and removed Priority-3 A description (P3) labels Feb 28, 2020
@zadjii-msft
Copy link
Member

I know @miniksa was mucking with the baselines in #5345, maybe this is related?

@tuscen
Copy link
Author

tuscen commented Apr 14, 2020

Looks like it was fixed. I do use a 4K display with 150% scaling.

1
2

@zadjii-msft
Copy link
Member

@tuscen that's excellent to hear. I'd usually love to have an actual commit to link this to for future people that run into this issue, but we've changed so much about our rendering stack since 0.8 that it'd be hard to pin this down exactly.

Thanks for following up though!

@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Apr 14, 2020
@zadjii-msft zadjii-msft added Resolution-No-Repro We couldn't get this to happen, or it stopped happening entirely. and removed Needs-Tag-Fix Doesn't match tag requirements labels Apr 14, 2020
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Apr 14, 2020
@hnakamur
Copy link

Sorry for late reporting, but my issue was also resolved since version: 0.10.781.0.
Thanks for a great product!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Fonts Related to the font Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Resolution-No-Repro We couldn't get this to happen, or it stopped happening entirely.
Projects
None yet
Development

No branches or pull requests

4 participants