Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate include order issue with InputBuffer, readData #4262

Open
zadjii-msft opened this issue Jan 16, 2020 · 1 comment
Open

Investigate include order issue with InputBuffer, readData #4262

zadjii-msft opened this issue Jan 16, 2020 · 1 comment
Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Priority-3 A description (P3) Product-Conhost For issues in the Console codebase
Milestone
Engineering Impro...

Comments

@zadjii-msft
Copy link
Member

Found in #4213.

I had to fwddecl InputBuffer, because I think there's a include order problem with in InputBuffer.hpp and readData.hpp.

readData.hpp uses InputBuffer in a bunch of places, but doesn't include it first

InputBuffer.hpp includes readData.hpp before it defines InputBuffer

So if you try to

#include ".../host/inputBuffer.hpp"

You'll get a compilation error, because it'll include readData, which will assume InputBuffer is defined, which it isn't yet.
@zadjii-msft zadjii-msft added Product-Conhost For issues in the Console codebase Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Priority-3 A description (P3) labels Jan 16, 2020
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jan 16, 2020
@zadjii-msft zadjii-msft mentioned this issue Jan 16, 2020
Merged
3 tasks
@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jan 23, 2020
@DHowett-MSFT
Copy link
Contributor

Triaged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Priority-3 A description (P3) Product-Conhost For issues in the Console codebase
Projects
None yet
Milestone
Engineering Improvements
Development

No branches or pull requests
2 participants
@DHowett-MSFT @zadjii-msft