Selection Color should invert selected text color

[javierdlg]

Environment

Windows build number: 10.0.18363.0
Windows Terminal version (if applicable): All

Steps to reproduce

1. Open the terminal.
2. Select some text.

Expected behavior

Selected text should invert the text colors:

Actual behavior

Text maintains it's original color which leads to contrast issues.

Notes

Powershell and CMD both invert the text colors when selected, which would fix the contrast ratio accessibility issue present in the terminal:

[zadjii-msft]

oh no

This is hard to very hard on the scale of tasks, unfortunately.

GDI has a very handy function for inverting the colors of a region of the window. unfortunately, DX has so such equivalent function. I believe @miniksa has said something in that past about rendering the frame, then specially inverting the selected area in another rendering pass? He can elaborate more.

[javierdlg]

How about being able to choose the selected text foreground color? This could potentially solve the contrast ratio issue on selected text and not force us to vet all the colors against two background colors for every theme.

[miniksa]

Didn't #3471 committed today literally just do this?

[mdtauk]

Didn't #3471 committed today literally just do this?

It only includes a Selection Background colour. I did make the suggestion there should also be a Selection Foreground colour.

[DHowett-MSFT]

We're open to contributions to our DX renderer. Thanks!