Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings Schema is Missing Initial Position and Launch Mode #3290

Closed
cinnamon-msft opened this issue Oct 22, 2019 · 0 comments · Fixed by #4222
Closed

Settings Schema is Missing Initial Position and Launch Mode #3290

cinnamon-msft opened this issue Oct 22, 2019 · 0 comments · Fixed by #4222
Assignees
@cinnamon-msft
Labels
Area-Schema Things that have to do with the json schema. Issue-Bug It either shouldn't be doing this or needs an investigation. Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v0.9

Comments

@cinnamon-msft
Copy link
Contributor

The settings schema doesn't have the latest settings for launching the Terminal as maximized nor setting the initial position on launch.

Settings to be added: "initialPosition" and "launchMode"

PR with new settings: #2817
@cinnamon-msft cinnamon-msft added the Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs label Oct 22, 2019
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Oct 22, 2019
@DHowett-MSFT DHowett-MSFT added Area-Schema Things that have to do with the json schema. Product-Terminal The new Windows Terminal. Issue-Bug It either shouldn't be doing this or needs an investigation. Mass-Chaos Temporary use to trigger the bot. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Oct 22, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Oct 22, 2019
@DHowett-MSFT DHowett-MSFT removed the Mass-Chaos Temporary use to trigger the bot. label Oct 22, 2019
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Oct 22, 2019
@DHowett-MSFT DHowett-MSFT added the Mass-Chaos Temporary use to trigger the bot. label Oct 22, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Oct 22, 2019
@DHowett-MSFT DHowett-MSFT removed the Mass-Chaos Temporary use to trigger the bot. label Oct 22, 2019
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Oct 22, 2019
@DHowett-MSFT DHowett-MSFT removed the Needs-Tag-Fix Doesn't match tag requirements label Oct 22, 2019
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Oct 22, 2019
@DHowett-MSFT DHowett-MSFT removed the Needs-Tag-Fix Doesn't match tag requirements label Oct 22, 2019
@zadjii-msft zadjii-msft added this to the Terminal v1.0 milestone Dec 19, 2019
@cinnamon-msft cinnamon-msft self-assigned this Jan 14, 2020
@cinnamon-msft cinnamon-msft mentioned this issue Jan 14, 2020
Merged
5 tasks
@ghost ghost added the In-PR This issue has a related PR label Jan 14, 2020
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cinnamon-msft cinnamon-msft

Labels
Area-Schema Things that have to do with the json schema. Issue-Bug It either shouldn't be doing this or needs an investigation. Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v0.9
Development

Successfully merging a pull request may close this issue.

Added initialPosition and launchMode to settings schema microsoft/terminal
3 participants
@DHowett-MSFT @zadjii-msft @cinnamon-msft