Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wpf control does not inform connection of resize in all cases #3227

Closed
ZoeyR opened this issue Oct 16, 2019 · 1 comment · Fixed by #3228
Closed

Wpf control does not inform connection of resize in all cases #3227

ZoeyR opened this issue Oct 16, 2019 · 1 comment · Fixed by #3228
Assignees
@ZoeyR
Labels
Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@ZoeyR
Copy link
Contributor

ZoeyR commented Oct 16, 2019

Environment

Expected behavior

When the Wpf control has to resize the buffer due to font changes or manual resize events the connection should get a corresponding message.

Actual behavior

The connection does not receive a message after the buffer resizes.
@ZoeyR ZoeyR self-assigned this Oct 16, 2019
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Oct 16, 2019
@ZoeyR ZoeyR mentioned this issue Oct 16, 2019
Merged
2 tasks
@ghost ghost added the In-PR This issue has a related PR label Oct 16, 2019
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Oct 16, 2019
@ghost
Copy link

ghost commented Oct 23, 2019

🎉This issue was addressed in #3228, which has now been successfully released as Windows Terminal Preview v0.6.2951.0.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ZoeyR ZoeyR

Labels
Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

correctly inform wpf pty connection of resize events microsoft/terminal
1 participant
@ZoeyR