Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - Hide close button on tabs - (or warn) #15544

Closed
nawlbergs opened this issue Jun 14, 2023 · 4 comments
Closed

Feature Request - Hide close button on tabs - (or warn) #15544

nawlbergs opened this issue Jun 14, 2023 · 4 comments
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@nawlbergs
Copy link

Description of the new feature/enhancement

Ability to remove the Close button on tabs... or Warn when closing a single tab.
Its not hard to accidently close a tab (especially if you rename the tab with a short name). I've done it many times.

Proposed technical implementation details (optional)

Setting (similar to "Warn when closing more than one tab") to remove the close button on tabs or Warn on single tab closure.
If Close button removed... right clicking would still allow you to close the tab. (obviously).

I want to not accidentally close tabs.

@nawlbergs nawlbergs added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Jun 14, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jun 14, 2023
@lhecker
Copy link
Member

lhecker commented Jun 14, 2023

You can hide the close button! Open your settings and click on "Open JSON file". Add the following to the end of the file under "themes":

{
    "name": "Dark (no close button)",
    "tab": 
    {
        "background": "terminalBackground",
        "showCloseButton": "never",
        "unfocusedBackground": "#00000000"
    },
    "tabRow": 
    {
        "background": null,
        "unfocusedBackground": "#333333FF"
    },
    "window": 
    {
        "applicationTheme": "dark",
        "useMica": false
    }
}

You can now select the "Dark (no close button)" in the Appearance settings

image

The only way to close the tab now is via Ctrl+Shift+W. We're working on a fix to close it via the middle mouse button over at #15517.

@zadjii-msft
Copy link
Member

Between the above answer and #5301 I'm gonna close this out. Thanks!

/dup #5301

@microsoft-github-policy-service
Copy link
Contributor

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@microsoft-github-policy-service microsoft-github-policy-service bot added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jun 15, 2023
@paaloeye
Copy link

You can hide the close button! Open your settings and click on "Open JSON file". Add the following to the end of the file under "themes":

{
"name": "Dark (no close button)",
"tab":
{
"background": "terminalBackground",
"showCloseButton": "never",
"unfocusedBackground": "#00000000"
},
"tabRow":
{
"background": null,
"unfocusedBackground": "#333333FF"
},
"window":
{
"applicationTheme": "dark",
"useMica": false
}
}
You can now select the "Dark (no close button)" in the Appearance settings

image

The only way to close the tab now is via Ctrl+Shift+W. We're working on a fix to close it via the middle mouse button over at #15517.

That's the best solution I found so far and can confirm it's working as advertised.
@lhecker Cheers for saving me countless hours of googling it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

4 participants