Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Quake Windows can be opened #15037

Open
SubsTheTechnomancer opened this issue Mar 23, 2023 · 9 comments
Open

Multiple Quake Windows can be opened #15037

SubsTheTechnomancer opened this issue Mar 23, 2023 · 9 comments
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Area-Windowing Window frame, quake mode, tearout Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.

Comments

@SubsTheTechnomancer
Copy link

Windows Terminal version

1.16.10261.0

Windows build number

22000.1696

Other Software

No response

Steps to reproduce

  • Open a WT Instance and enter wt -w _quake
  • With the quake window open, enter the shortcut keys for opening/closing a quake window (In my case, Win + `)

Expected Behavior

The already open quake window should minimize as is normal while using the quake shortcut.

Actual Behavior

A different quake window opens either above the current quake window or on the currently active screen (if using multiple screens).

@SubsTheTechnomancer SubsTheTechnomancer added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Mar 23, 2023
@SubsTheTechnomancer
Copy link
Author

This might be related to #14957. I would have dismissed this as intended behaviour if not for the tip and tricks page provided (https://learn.microsoft.com/en-us/windows/terminal/tips-and-tricks). As an aside, I'm not sure what the intended behaviour is if, for example, you were to re-enter wt -w _quake a second time. Currently it creates a new tab in the existing quake window but I don't see any documentation related to this.

@zadjii-msft
Copy link
Member

Do you have both Terminal Preview and Terminal stable installed? Are you possibly running one Terminal instance elevated (as admin)/?

I'd be sure that this isn't #14957 - that's only just been checked in and is only available on internal 1.18 builds.

Doing wt -w _quake a second time perhaps isn't documented the best. That implicitly turns into wt -w _quake new-tab, which essentially turns into "open a new tab in the window named _quake".

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Mar 23, 2023
@SubsTheTechnomancer
Copy link
Author

SubsTheTechnomancer commented Mar 27, 2023

Are you possibly running one Terminal instance elevated (as admin)/?

By default, my terminal instances are elevated, yes. Is that the reason for this behaviour?

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Mar 27, 2023
@zadjii-msft
Copy link
Member

Probably - though, there should only be one _quake window for the elevated instances, and one single _quake window for the unelevated ones.

Can you check something for me quick/? In each of the open _quake windows, can you open the Command Palette (ctrl+shift+p), then perform the "Toggle focus mode" action? That should make the titlebar (and tabs) of the _quake window visible. Do both windows have a sheild icon in the top left, like so:

image

If they both do, that's very peculiar, and I might want to take a look at your settings.json file next.

If they DON'T both have one, then this is totally by design.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Attention The core contributors need to come back around and look at this ASAP. labels Mar 27, 2023
@SubsTheTechnomancer
Copy link
Author

I did this, and yeah, the one instantiated by the command is not an elevated terminal, so it does seem to be by design.
Unfortunately, then, I'm not sure how I would open an elevated quake window with the command, unless this is already documented.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Mar 27, 2023
@zadjii-msft
Copy link
Member

Alright I think this is crazy. But here's my thoughts on what's going on

  • you launch WT unelevated. This takes the global hotkeys.
  • We evaluate the settings, and relaunch as an elevated instance. (presumably due to profiles.defaults.elevated=true).
  • You launch wt -w _quake, which creates an elevated quake window.
  • You press the hotkey - this somehow runs in the unelevated instance.

The issue that for some reason, the unelevated terminal instance is still running. Only one process can hold on to the global hotkeys.

The issue is that there's that first unelevated instance that's still running. That would be something to investigate.

@zadjii-msft zadjii-msft removed their assignment Mar 29, 2023
@zadjii-msft zadjii-msft added Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. Area-Windowing Window frame, quake mode, tearout and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Attention The core contributors need to come back around and look at this ASAP. labels Mar 29, 2023
@SubsTheTechnomancer
Copy link
Author

I believe you may have swapped which instance in elevated and which is not, but I think the problem is still the same, except that it is the elevated instance that is getting priority over the global hotkeys.

@cypherfunc
Copy link

related/repeat of #11478?

@cypherfunc
Copy link

For reference, none of my quake tabs are elevated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Area-Windowing Window frame, quake mode, tearout Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

3 participants