Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Terminal doesn't start from folder right-click menu #14369

Open
gyorokpeter opened this issue Nov 10, 2022 · 10 comments
Open

Windows Terminal doesn't start from folder right-click menu #14369

gyorokpeter opened this issue Nov 10, 2022 · 10 comments
Labels
Area-ShellExtension For issues related to the explorer right-click context menu Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.
Milestone

Comments

@gyorokpeter
Copy link

Windows Terminal version

1.15.2875.0

Windows build number

10.0.22621.819

Other Software

N/A

Steps to reproduce

After installing Windows Terminal, right click in any folder in Windows Explorer and choose "Open in Terminal".

Expected Behavior

Terminal should start up.

Actual Behavior

Nothing happens.
However Terminal works if started by other means, such as by running it from the start menu, so the problem must be in the context menu launch method.

@gyorokpeter gyorokpeter added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Nov 10, 2022
@zadjii-msft
Copy link
Member

We might need a feedback hub trace on this, so we can get the context menu folks to take a look. I don't recall off the top of my head what the area path for the shell context menu is. The bot will tell you to file this under the "Terminal" path, but you should look for a context menu path instead. (alas, feedback hub is busted on my machine ATM, so I can't figure that out for you).

/feedback

@ghost
Copy link

ghost commented Nov 11, 2022

Hi there!

Can you please send us feedback with the Feedback Hub with this issue? Make sure to click the "Start recording" button, then reproduce the issue before submitting the feedback. Once it's submitted, paste the link here so we can more easily find your crash information on the back end?

Thanks!

image

image

image

@ghost ghost added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Nov 11, 2022
@gyorokpeter
Copy link
Author

https://aka.ms/AAippyc

@carlos-zamora
Copy link
Member

Hmm. Could you try doing this?

  1. Open Windows Terminal
  2. Open the drop down menu
  3. shift+click a profile

Does a terminal launch in a new window? This may help us diagnose what specifically is failing.

@carlos-zamora carlos-zamora added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Attention The core contributors need to come back around and look at this ASAP. labels Dec 7, 2022
@gyorokpeter
Copy link
Author

That opens a folder in Windows Explorer with the name %LOCALAPPDATA%\Microsoft\WindowsApps\Microsoft.WindowsTerminalPreview_8wekyb3d8bbwe\wt.exe . It's a folder but it's named like an executable file.

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Dec 7, 2022
@carlos-zamora
Copy link
Member

Awesome. Could you run this command:
fsutil reparsepoint query %LOCALAPPDATA%\Microsoft\WindowsApps\Microsoft.WindowsTerminalPreview_8wekyb3d8bbwe\wt.exe

It looks like your app execution alias might be broken (as you've probably guessed).

@carlos-zamora carlos-zamora removed the Needs-Attention The core contributors need to come back around and look at this ASAP. label Dec 7, 2022
@gyorokpeter
Copy link
Author

It says "Error: The file or directory is not a reparse point" (in Hungarian).

@zadjii-msft
Copy link
Member

Well that's entirely unexpected! I honestly have no idea how that would happen. You might want to back up your settings.json file file (and possibly state.json in that folder too), delete the bad "wt.exe" folder, and reinstall the Terminal. I have no idea how that would get created as a folder instead of as the app execution alias / reparse point...

@zadjii-msft zadjii-msft added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Dec 8, 2022
@gyorokpeter
Copy link
Author

I managed to recreate the symlinks. Now the shift-click method works in a terminal window, but the right-click menu in a folder still doesn't.

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Dec 8, 2022
@carlos-zamora carlos-zamora added Product-Terminal The new Windows Terminal. Area-ShellExtension For issues related to the explorer right-click context menu labels Jan 25, 2023
@carlos-zamora
Copy link
Member

Sorry for the delay, finally coming back to this. It looks like #14637 has presented a potential solution. We would just need some time to implement a similar thing for the shell extension.

@carlos-zamora carlos-zamora added this to the Terminal v1.18 milestone Jan 25, 2023
@carlos-zamora carlos-zamora removed Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jan 25, 2023
@zadjii-msft zadjii-msft removed this from the Terminal v1.18 milestone May 12, 2023
@zadjii-msft zadjii-msft added this to the Terminal v1.19 milestone May 12, 2023
@zadjii-msft zadjii-msft modified the milestones: Terminal v1.19, Backlog Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-ShellExtension For issues related to the explorer right-click context menu Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

3 participants