Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent rendering of characters #14232

Closed
edemaine opened this issue Oct 15, 2022 · 6 comments
Closed

Inconsistent rendering of characters #14232

edemaine opened this issue Oct 15, 2022 · 6 comments
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting

Comments

@edemaine
Copy link

edemaine commented Oct 15, 2022

Windows Terminal version

1.15.2713.0

Windows build number

10.0.22000.1098

Other Software

Cygwin vim 8.2
zsh 5.8

Steps to reproduce

Type in some text such as console.log 'hello', palette in vim or zsh

Possible relevant:

  • System / Display / Custom scaling of 135%
  • 3840x2160 monitor
  • Font is Hack FC Ligatured at 14pt. Also tried a more vanilla Hack with similar effects.
  • Text antialiasing set to ClearType. (Also tried Grayscale with similar effects.)
  • No apparent difference with "Redraw entire screen" or "Use software rendering" turned on.

Expected Behavior

Identical characters to look similar

Actual Behavior

Some strokes look thicker than they should, with possible overdraw.

In Vim: look at weird s and different os

image

In zsh: look at different hs and ls

image

@edemaine edemaine added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Oct 15, 2022
@lhecker
Copy link
Member

lhecker commented Oct 17, 2022

Do you have the "AtlasEngine" feature enabled under the "Rendering" settings? Could you try toggling the switch and restarting Windows Terminal to see how the other rendering mode works for you?

@zadjii
Copy link

zadjii commented Oct 17, 2022

This is #4591

@edemaine
Copy link
Author

Agreed, @zadjii, this seems like the same as #4591. Thanks for spotting. (I did try to look for scaling issues, but missed this one.)

@lhecker I don't see an AtlasEngine option. Is it one of the following?

image

@lhecker
Copy link
Member

lhecker commented Oct 17, 2022

Ah sorry, I thought we had merged that into the 1.15 release branch as well. If you install Windows Terminal Preview (1.16) the issue will most likely not occur anymore.

@edemaine
Copy link
Author

Oh, thanks. On 1.16.2642.0 with Atlas turned on (as is the default), I see a different issue:

image

Both lines should be identical, but the top one has weird rendering. Moving lines up and down consistently misdraws the top line (whichever one is in the second row of the window).

Perhaps clearer with antialiasing turned off:

image

I assume this is also #4591, or should I open a different issue?

@lhecker
Copy link
Member

lhecker commented Oct 17, 2022

Interesting! I'd say it's the same issue even if it behaves slightly different. I suspect this is a bug in Direct2D which we can't do that much about just yet as we depend heavily on it. But I'll have to look into it first...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting
Projects
None yet
Development

No branches or pull requests

3 participants