Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.16] wt nt ; nt ; nt might be different now #13480

Closed
zadjii-msft opened this issue Jul 11, 2022 · 4 comments
Closed

[1.16] wt nt ; nt ; nt might be different now #13480

zadjii-msft opened this issue Jul 11, 2022 · 4 comments
Labels
Area-Commandline wt.exe's commandline arguments Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-1 A description (P1) Product-Terminal The new Windows Terminal.
Milestone
Terminal v1.16

Comments

@zadjii-msft
Copy link
Member

A note from a Teams discussion I don't want to lose. #13421 might have changed the behavior here. We'll spin a 1.16 selfhost soon we can use to check.
@zadjii-msft zadjii-msft added Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Priority-1 A description (P1) Area-Commandline wt.exe's commandline arguments labels Jul 11, 2022
@zadjii-msft zadjii-msft added this to the Terminal v1.16 milestone Jul 11, 2022
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 11, 2022
@zadjii-msft
Copy link
Member Author

This seems okay to me. With the new afterCurrentTab setting:

wt -w 3 nt -p HONK ; nt -- pwsh ; nt ; nt -p HONK

With the first cmd and settings tab opened, this created:
image
(HONK is green)

Again with pwsh selected:

image
The blue tabs were added on the first run, the red on the second. This seems fine to me.

@zadjii-msft zadjii-msft closed this as not planned Won't fix, can't repro, duplicate, stale Jul 29, 2022
@DHowett
Copy link
Member

DHowett commented Jul 29, 2022

How about from a clean launch with no tabs open? Do we get the order right?

@zadjii-msft
Copy link
Member Author

How about from a clean launch with no tabs open? Do we get the order right?

Seems right to me.
image

  • The first tab is created at the end, so after current == at end
  • the N'th tab is created at the end -> the current tab becomes the Nth -> the end is also the Nth

@DHowett
Copy link
Member

DHowett commented Jul 29, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Commandline wt.exe's commandline arguments Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-1 A description (P1) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Terminal v1.16
Development

No branches or pull requests
2 participants
@DHowett @zadjii-msft