Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bold text on active tab causes the tab size to "jiggle" when focused/unfocused #12574

Closed
Tracked by #12400
Piroro-hs opened this issue Feb 25, 2022 · 3 comments
Closed
Tracked by #12400

Bold text on active tab causes the tab size to "jiggle" when focused/unfocused #12574

Piroro-hs opened this issue Feb 25, 2022 · 3 comments
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Won't-Fix We're just really obstinate about this. There's probably a good reason.
Milestone
Backlog

Comments

@Piroro-hs
Copy link

Piroro-hs commented Feb 25, 2022 •
edited
Loading

Windows Terminal version

1.13.10336.0

Windows build number

10.0.19044.1526

Other Software

No response

Steps to reproduce

  1. Open 2 or more tabs in Terminal
  2. Repeat Ctrl + Tab

Expected Behavior

Things stay on same position

Actual Behavior

PowerShell vibration

Terminal.Preview.2022-02-25.11-25-15.mp4
@Piroro-hs Piroro-hs added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Feb 25, 2022
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Feb 25, 2022
@zadjii-msft
Copy link
Member

@gabbybilka as an FYI.

I'll link this up to #12400. We'll probably need to track this upstream too. I'm not sure there's immediately any way for us to control the styling of the focused tab such that we can prevent it from getting bolded like that.

@zadjii-msft zadjii-msft changed the title Active and inactive tabs are inconsistent about icon and title position Bold text on active tab causes the tab size to "jiggle" when focused/unfocused Feb 25, 2022
@zadjii-msft zadjii-msft added Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels Feb 25, 2022
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Feb 25, 2022
@zadjii-msft zadjii-msft mentioned this issue Feb 25, 2022
Open
12 tasks
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Feb 25, 2022
@DHowett DHowett added this to the 22H1 milestone Feb 25, 2022
@zadjii-msft zadjii-msft modified the milestones: 22H1, Backlog Aug 3, 2022
@zadjii-msft
Copy link
Member

I'm gonna tag this up for discussion - honestly, we've been shipping with this for a year now, and there hasn't been an overwhelming amount of complaints. I didn't love it at first, but the bold text does add a little bit more emphasis to help ID the active tab. We may as well just leave this.

@zadjii-msft zadjii-msft added Resolution-Won't-Fix We're just really obstinate about this. There's probably a good reason. Needs-Discussion Something that requires a team discussion before we can proceed and removed Needs-Discussion Something that requires a team discussion before we can proceed labels Aug 21, 2023
@zadjii-msft
Copy link
Member

Yea our consensus was that if anything, this should be filed upstream over at https://github.com/microsoft/microsoft-ui-xaml.

@zadjii-msft zadjii-msft closed this as not planned Won't fix, can't repro, duplicate, stale Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Won't-Fix We're just really obstinate about this. There's probably a good reason.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@DHowett @zadjii-msft @Piroro-hs