Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analyze PGO profiles during EIM #11688

Open
miniksa opened this issue Nov 4, 2021 · 0 comments
Open

Analyze PGO profiles during EIM #11688

miniksa opened this issue Nov 4, 2021 · 0 comments
Labels
Area-Build Issues pertaining to the build system, CI, infrastructure, meta Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Milestone
Engineering Impro...

Comments

@miniksa
Copy link
Member

miniksa commented Nov 4, 2021

@dmachaj noticed that a good chunk of our boot work is in .text$zz... so it's not in the PGO training.

When I put the initial PGO training tests in at https://github.com/microsoft/terminal/blob/main/src/cascadia/WindowsTerminal_UIATests/SmokeTests.cs, it was like the bare minimum to get us going on the PGO stuff.

EIM is probably a good time to revisit that and check how effective they're actually being and whether we need to make adjustments to the training set.
@miniksa miniksa added Area-Build Issues pertaining to the build system, CI, infrastructure, meta Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. labels Nov 4, 2021
@miniksa miniksa added this to the Engineering Improvements 2021 milestone Nov 4, 2021
@miniksa miniksa self-assigned this Nov 4, 2021
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Nov 4, 2021
@miniksa miniksa removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Nov 4, 2021
@miniksa miniksa mentioned this issue Nov 10, 2021
Closed
@miniksa miniksa removed their assignment Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Build Issues pertaining to the build system, CI, infrastructure, meta Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Engineering Improvements
Development

No branches or pull requests
2 participants
@miniksa @zadjii-msft